Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two categories of improvement to scale-test:
Revive the direct linear regression code as a first-pass (not in log-space) to catch cases that best-fit linearly with no higher-degree exponent term. These cases occur in practice pretty often when someone has a process that's linear "once it gets going" with a sub- or super-linear first point; these presently cause the simplex-algorithm to continue to tweak the polynomial model's exponent to find a curve that fits the extra point, rather than just tilting a line, and it winds up with a bad overall fit (fails, requires more data, etc). Checking a line first (as with the constant early-check) is worthwhile. This also lets us tighten bounds a bit on tests.
Complete some work started in 93a832d to make scale-test use the same stats-dir parsing code as process-stats-dir, to use the -stats-output-dir reporting mode of the compiler (not -Xllvm -stats-json) when it's available. This gives us more stats, and also usable scale-testing on non-assert (i.e. end-user) compilers, for the stats we ship in that mode.