Serialize SIL for default argument generators in Swift 4 mode #11937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
serialize-default-argument-generators
branch
from
fe56610 to
47b11b4
Compare
…unctionDecl Previously we stored this inside each default argument initializer context. This was overkill, because it is the same for all default arguments in a single function, and also insufficient, because initializer contexts are not serialized and thus not available in SILGen when the function is in a different module. Instead store it directly inside the function and serialize it. NFC for now, since SILGen isn't using this yet.
slavapestov
force-pushed
the
serialize-default-argument-generators
branch
from
47b11b4 to
d736501
Compare
|
@swift-ci Please test |
slavapestov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on rdar://problem/33767513.