Re-apply "Preserve SIL when merging modules" #11943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The witness table had shared linkage, but we weren't serializing them, which would cause linking errors if we emitted a reference to such a witness table from a different module than the one where it was first defined, as a result of deserializing and optimizing SIL. This issue was introduced when SIL witness table serialization was made conditional on the -sil-serialize-witness-tables flag, which is normally only enabled for the standard library. When the flag was added, existing tests were updated to pass the flag, which masked the issue. Remove the flag from existing tests, ensure that imported witness tables are still [serialized], and add a new test specifically for the behavior enabled by this flag.
We were inlining the size and alignment, which was not correct. This was the cause of a long-standing ASAN failure in some library evolution tests. Fixes <rdar://problem/24540778>.
This test used to fail because we would look up an associated type in an incomplete conformance after Sema was torn down, causing a crash. Now, the ClangImporter is able to correctly complete the conformance.
Also pass flags to disable SIL optimization passes when merging modules, since that's completely unnecessary. An evolution test that used to fail with WMO disabled now passes with this change. FIxes <rdar://problem/18913977>.
|
@swift-ci Please smoke test |
|
@swift-ci Please ASAN test |
abadi4279
reviewed
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to revert #8388 in #11938 because
check-swift-validation-optimizewas failing.This PR fixes two issues exposed by running the tests with optimizations and re-applies the original changes: