[Parser] Fix-it for declaration attributes being applied to parameter types (SR-215) #1197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
This looks good at first glance -- do you mind squashing the two commits together? Also it looks like the commit message on the first one is wrong (it's not really fixing a typo -- it's implementing the whole change) |
SquaredTiki
force-pushed
the
sr215-fix
branch
from
95c4ba2 to
7d67fc5
Compare
|
@slavapestov I've squashed them all together now and fixed a build failure noticed by the CI. |
|
@swift-ci Please test |
|
@SquaredTiki Do you feel this diagnostic is still relevant to Swift 3? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR #673 but reverted due to test failures and later due to typo. Third time's a charm, eh? CI should spot anything now which is a neat addition. Original description:
As described in SR-215, previously the fix-it was suggesting that declaration attributes applied to parameter types be moved to before the function func declaration itself.
This pull request fixes this so that it is instead moved to before the parameter name.