runtime: make LLP64 clean #11976
Merged
runtime: make LLP64 clean #11976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Build failed |
|
Don't think that the foundation failure is related (network flakiness?) @swift-ci please test Linux platform |
compnerd
commented
Sep 18, 2017
include/swift/Runtime/Metadata.h
Outdated
| @@ -660,7 +660,7 @@ const ExtraInhabitantsValueWitnessTable METATYPE_VALUE_WITNESS_SYM(Bo); // Built | |||
|
|
|||
| /// Return the value witnesses for unmanaged pointers. | |||
| static inline const ValueWitnessTable &getUnmanagedPointerValueWitnesses() { | |||
| #ifdef __LP64__ | |||
| #ifdef __POINTER_WIDTH__ == 64 | |||
There was a problem hiding this comment.
Oops, I uploaded the wrong version This should be #if __POINTER_WIDTH__ == 64.
This is a blanket pass replacing use of `__LP64__` with `__POINTER_WIDTH__ == 64`. The latter is more expressive and also LLP64 clean. This change is needed to enable support for Windows x86_64 which is a LLP64 environment.
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
The macOS failure seems unrelated. "ld: can't write output file: - for architecture i386" @swift-ci please test macOS platform |
gparker42
approved these changes
Sep 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a blanket pass replacing use of
__LP64__with__POINTER_WIDTH__ == 64. The latter is more expressive and also LLP64clean. This change is needed to enable support for Windows x86_64 which
is a LLP64 environment.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.