Fixes for @_versioned attribute #11979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ations It looks like at some point derived conformances were in their own FileUnit, but this is no longer the case.
…ioned enums The synthesized declarations should inherit the @_versioned attribute from the type, just like they inherit access control. Fixes <rdar://problem/34342955>.
|
@swift-ci Please smoke test |
|
I think the "at least internal" bit goes with the defaulting behavior of SE-0025, not the cross-file thing from Equatable enums. |
|
Also, it's necessary to get the correct behavior for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://problem/34342955.