Skip to content

Add -Onone to all the _Debug tests #11985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2017
Merged

Add -Onone to all the _Debug tests #11985

merged 1 commit into from
Sep 18, 2017

Conversation

lancep
Copy link
Contributor

@lancep lancep commented Sep 18, 2017

There are tests that expect to be run in a debug configuration but that are not using -Onone, we should explicitly ask for optimization parameters that we are expecting to test.

rdar://problem/27834462

@lancep
Copy link
Contributor Author

lancep commented Sep 18, 2017

@swift-ci please smoke test

@lancep lancep requested review from rintaro, moiseev, milseman, lorentey and airspeedswift and removed request for rintaro September 18, 2017 21:14
Copy link
Member

@milseman milseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lancep lancep merged commit da22d25 into swiftlang:master Sep 18, 2017
@lancep lancep deleted the debugTestsShouldDisableOptimizations branch September 18, 2017 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants