Allow "protocol P : class, AnyObject..." for Swift 4 compatibility. #11989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the way we modeled the 'class' constraint in Swift <= 4, we allowed both 'class' and 'AnyObject' to be specified on a protocol, even in Swift 4 when they became equivalent. Recent refactoring started rejecting such code; allow it now. Fixes rdar://problem/34496151. (cherry picked from commit d0aa22c)
|
@swift-ci please test |
|
LGTM |
slavapestov
approved these changes
Sep 18, 2017
|
@swift-ci Please nominate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: A simplification to the handling of the deprecated
classconstraint introduced as part of #11786 (for rdar://problem/34274386) started rejecting protocols such asprotocol P : class, AnyObject { }, turning a warning into an error. Address this source-compatibility break by downgrading the error in that specific case to a warning.Scope: Very narrow; downgrades a specific error to a warning.
Radar: rdar://problem/34496151
Risk: Very low; only affects one code path where we are already emitting a warning.
Testing: Compiler regression tests.
Reviewed By: @slavapestov