Reapply "merge partial SIL modules" again #11995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also pass flags to disable SIL optimization passes when merging modules, since that's completely unnecessary. An evolution test that used to fail with WMO disabled now passes with this change. FIxes <rdar://problem/18913977>.
When merging partial SIL modules we only link in function bodies defined in the current module, so we might encounter functions with shared linkage and no body. Since pulling in these functions from other modules is a waste of time, run the verifier in "single function" mode in this case. Note that when the module is ultimately used and one of these functions is deserialized, we should link in all downstream functions with shared linkage, and failure to do so will be caught by the SIL verifier then. Fixes <rdar://problem/34469704>.
slavapestov
force-pushed
the
reapply-merge-partial-sil-modules-again
branch
from
df50ffa to
6478256
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux |
|
@swift-ci Please clean test Linux |
|
Build failed |
|
@swift-ci Please clean test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another fix and another re-attempt at re-enabling this. Fingers crossed!