Skip to content

Revert "Create fewer generic signature builders" #12075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2017

Conversation

shajrawi
Copy link

Trying non-smoke test that reverts #12062

See if it fixes the validation tests

@shajrawi
Copy link
Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 00f44ce

@DougGregor
Copy link
Member

@shajrawi can you give me a few minutes to look into this?

@DougGregor
Copy link
Member

(I'll merge your PR this evening if I can't get a fix in fast)

@shajrawi
Copy link
Author

Sure thing - no worries

@CodaFi
Copy link
Contributor

CodaFi commented Sep 23, 2017

@swift-ci please clean test Linux platform

@DougGregor
Copy link
Member

Ugh. Cannot reproduce this, and ci.swift.org is being unresponsive tonight

@CodaFi
Copy link
Contributor

CodaFi commented Sep 23, 2017

Seems cleared up on my end. The failures appear in SIL/parse_stdlib_*

@DougGregor DougGregor merged commit cf78384 into master Sep 23, 2017
@DougGregor DougGregor deleted the revert-12062-make-fewer-gsbs branch September 23, 2017 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants