Skip to content

Switch TypeJoin over to being a CanTypeVisitor. #12087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 25, 2017
Merged

Switch TypeJoin over to being a CanTypeVisitor. #12087

merged 2 commits into from
Sep 25, 2017

Conversation

rudkx
Copy link
Contributor

@rudkx rudkx commented Sep 25, 2017

No description provided.

@rudkx
Small clean-ups to Type::join.
16cae69 
We shouldn't need to check for Type() in getSuperclassJoin(). We can
also just call join() directly rather than TypeJoin::join(), since it's
the only join() in scope.
@rudkx
Switch TypeJoin over to being a CanTypeVisitor.
c4fa057
@rudkx
Copy link
Contributor Author

rudkx commented Sep 25, 2017

@swift-ci Please smoke test

@rudkx
Copy link
Contributor Author

rudkx commented Sep 25, 2017

@swift-ci Please test source compatibility

@rudkx
Copy link
Contributor Author

rudkx commented Sep 25, 2017

@swift-ci Please test compiler performance

@swiftlang swiftlang deleted a comment from swift-ci Sep 25, 2017
@swift-ci
Copy link
Contributor

Build comment file:

Summary for master smoketest

Regressions found (see below)

Debug

PR vs. head (debug)

PR vs. head, changed counters (debug)

name old new delta delta_pct
ReactiveCocoa.AST.NumReferencedDynamicNames 2 3 1 50.0
ReactiveCocoa.IRModule.NumIRAliases 6 8 2 33.33
ReactiveCocoa.SILModule.NumSILGenGlobalVariables 52 64 12 23.08
ReactiveCocoa.SILModule.NumSILGenWitnessTables 38 44 6 15.79
ReactiveCocoa.SILModule.NumSILOptWitnessTables 58 66 8 13.79
ReactiveCocoa.AST.NumPrecedenceGroups 56 62 6 10.71
ReactiveCocoa.Sema.NumConformancesDeserialized 17642 19299 1657 9.39
ReactiveCocoa.AST.NumUsedConformances 310 338 28 9.03
ReactiveSwift.Driver.ChildrenMaxRSS 253784064 275734528 21950464 8.65
ReactiveCocoa.AST.NumDependencies 1872 2028 156 8.33
ReactiveCocoa.AST.NumSourceBuffers 2448 2652 204 8.33
ReactiveCocoa.IRModule.NumIRNamedMetaData 144 156 12 8.33
ReactiveCocoa.IRModule.NumIRGlobals 4650 5034 384 8.26
ReactiveCocoa.Sema.NumLazyGenericEnvironments 44988 48610 3622 8.05
ReactiveCocoa.IRModule.NumIRValueSymbols 7002 7565 563 8.04
ReactiveCocoa.AST.NumReferencedTopLevelNames 536 579 43 8.02
ReactiveCocoa.AST.NumLoadedModules 1700 1836 136 8.0
ReactiveCocoa.LLVM.NumLLVMBytesOutput 3022976 3261664 238688 7.9
ReactiveCocoa.Sema.NumTypesDeserialized 222585 240180 17595 7.9
ReactiveCocoa.Sema.NumLazyGenericEnvironmentsLoaded 4694 5058 364 7.75
ReactiveCocoa.Sema.NumDeclsDeserialized 245207 264092 18885 7.7
ReactiveCocoa.Sema.NumTypesValidated 20374 21900 1526 7.49
ReactiveCocoa.AST.NumDecls 188 202 14 7.45
ReactiveCocoa.Sema.NumLazyIterableDeclContexts 50618 54383 3765 7.44
ReactiveCocoa.IRModule.NumIRFunctions 3346 3594 248 7.41
ReactiveCocoa.Sema.NumUnloadedLazyIterableDeclContexts 37282 40035 2753 7.38
ReactiveCocoa.AST.NumSourceLinesPerSecond 3724 3993 269 7.22
ReactiveCocoa.IRModule.NumIRBasicBlocks 5403 5780 377 6.98
ReactiveCocoa.AST.NumASTBytesAllocated 191306899 204269956 12963057 6.78
ReactiveCocoa.Sema.NominalTypeLookupDirectCount 449290 478866 29576 6.58
ReactiveCocoa.Sema.NumGenericSignatureBuilders 23936 25498 1562 6.53
ReactiveCocoa.IRModule.NumIRInsts 42415 45126 2711 6.39
ReactiveCocoa.AST.NumTotalClangImportedEntities 50278 53368 3090 6.15
ReactiveCocoa.AST.NumSourceLines 2088 2214 126 6.03
ReactiveCocoa.SILModule.NumSILOptGlobalVariables 234 248 14 5.98
Result.Driver.ChildrenMaxRSS 216100864 228986880 12886016 5.96
ReactiveCocoa.SILModule.NumSILOptFunctions 1884 1995 111 5.89
ReactiveCocoa.SILModule.NumSILGenFunctions 1246 1312 66 5.3
ReactiveCocoa.AST.NumImportedExternalDefinitions 16870 17756 886 5.25
ReactiveCocoa.Sema.NumFunctionsTypechecked 9576 9993 417 4.35
ReactiveCocoa.Sema.NumDeclsValidated 42086 43836 1750 4.16
ReactiveCocoa.Sema.NumConstraintScopes 15258 15879 621 4.07
Kingfisher.AST.NumSourceLinesPerSecond 9599 9943 344 3.58
ReactiveCocoa.AST.NumReferencedMemberNames 5520 5673 153 2.77
Result.AST.NumSourceLinesPerSecond 1331 1337 6 0.45
Kingfisher.AST.NumASTBytesAllocated 289174375 289219927 45552 0.02
Alamofire.AST.NumASTBytesAllocated 119869586 119881776 12190 0.01
ReactiveCocoa.Driver.ChildrenMaxRSS 270041088 262713344 -7327744 -2.71
Alamofire.AST.NumSourceLinesPerSecond 7081 6669 -412 -5.82
Alamofire.Driver.ChildrenMaxRSS 205291520 192311296 -12980224 -6.32
Kingfisher.Driver.ChildrenMaxRSS 339345408 297562112 -41783296 -12.31

PR vs. head, changed timers (debug)

name old new delta delta_pct

PR vs. baseline (debug)

PR vs. baseline, changed counters (debug)

name old new delta delta_pct
ReactiveSwift.Driver.ChildrenMaxRSS 201080832 275734528 74653696 37.13
Alamofire.Driver.ChildrenMaxRSS 160178176 192311296 32133120 20.06
Kingfisher.Driver.ChildrenMaxRSS 270966784 297562112 26595328 9.81
Kingfisher.IRModule.NumIRGlobals 8465 9079 614 7.25
ReactiveCocoa.Driver.ChildrenMaxRSS 247894016 262713344 14819328 5.98
Kingfisher.Sema.NumConstraintScopes 299224 316766 17542 5.86
Kingfisher.SILModule.NumSILOptFunctions 7508 7770 262 3.49
Alamofire.SILModule.NumSILOptFunctions 3897 4004 107 2.75
Kingfisher.IRModule.NumIRValueSymbols 14256 14506 250 1.75
Alamofire.LLVM.NumLLVMBytesOutput 2998660 3034304 35644 1.19
Kingfisher.LLVM.NumLLVMBytesOutput 4714840 4766756 51916 1.1
Alamofire.Sema.NumLazyGenericEnvironments 29624 29755 131 0.44
Alamofire.AST.NumUsedConformances 435 436 1 0.23
Alamofire.Sema.NumDeclsDeserialized 193887 193862 -25 -0.01
Kingfisher.SILModule.NumSILGenFunctions 4186 4182 -4 -0.1
Alamofire.SILModule.NumSILGenFunctions 2463 2460 -3 -0.12
Alamofire.IRModule.NumIRGlobals 4765 4753 -12 -0.25
Alamofire.Sema.NumGenericSignatureBuilders 14041 13983 -58 -0.41
Kingfisher.Sema.NumLazyGenericEnvironments 65834 65552 -282 -0.43
Kingfisher.Sema.NumDeclsDeserialized 409158 404540 -4618 -1.13
Alamofire.Sema.NumTypesDeserialized 160268 158195 -2073 -1.29
Alamofire.Sema.NumFunctionsTypechecked 5545 5454 -91 -1.64
Kingfisher.Sema.NumTypesDeserialized 349057 340784 -8273 -2.37
Alamofire.IRModule.NumIRValueSymbols 8767 8537 -230 -2.62
Kingfisher.Sema.NumGenericSignatureBuilders 33860 32819 -1041 -3.07
Kingfisher.IRModule.NumIRInsts 191952 184777 -7175 -3.74
Alamofire.IRModule.NumIRFunctions 5357 5146 -211 -3.94
Kingfisher.IRModule.NumIRFunctions 8166 7770 -396 -4.85
Kingfisher.IRModule.NumIRBasicBlocks 18918 17915 -1003 -5.3
Alamofire.Sema.NumLazyIterableDeclContexts 22171 20983 -1188 -5.36
Kingfisher.Sema.NumLazyIterableDeclContexts 56700 53413 -3287 -5.8
Alamofire.Sema.NumConstraintScopes 43672 41089 -2583 -5.91
Alamofire.AST.NumImportedExternalDefinitions 8503 7982 -521 -6.13
Kingfisher.Sema.NumFunctionsTypechecked 17534 16432 -1102 -6.28
Kingfisher.Sema.NumLazyGenericEnvironmentsLoaded 5754 5330 -424 -7.37
Alamofire.IRModule.NumIRBasicBlocks 15117 13989 -1128 -7.46
Alamofire.IRModule.NumIRInsts 145727 134400 -11327 -7.77
Kingfisher.AST.NumImportedExternalDefinitions 28992 26636 -2356 -8.13
Alamofire.Sema.NumLazyGenericEnvironmentsLoaded 2712 2462 -250 -9.22
Alamofire.AST.NumTotalClangImportedEntities 27870 24791 -3079 -11.05
Kingfisher.AST.NumTotalClangImportedEntities 75080 65970 -9110 -12.13
Kingfisher.Sema.NumTypesValidated 27830 23354 -4476 -16.08
Alamofire.Sema.NumTypesValidated 18294 14658 -3636 -19.88
ReactiveCocoa.LLVM.NumLLVMBytesOutput 4788084 3261664 -1526420 -31.88
Kingfisher.Sema.NumDeclsValidated 125016 83066 -41950 -33.56
Alamofire.Sema.NumConformancesDeserialized 47410 31381 -16029 -33.81
Kingfisher.Sema.NumConformancesDeserialized 111869 70994 -40875 -36.54
Alamofire.Sema.NumDeclsValidated 61341 38708 -22633 -36.9
ReactiveCocoa.IRModule.NumIRGlobals 8940 5034 -3906 -43.69
ReactiveCocoa.IRModule.NumIRValueSymbols 13956 7565 -6391 -45.79
ReactiveCocoa.Sema.NumFunctionsTypechecked 18516 9993 -8523 -46.03
ReactiveCocoa.Sema.NumLazyGenericEnvironments 91258 48610 -42648 -46.73
ReactiveCocoa.Sema.NumTypesDeserialized 454647 240180 -214467 -47.17
ReactiveCocoa.Sema.NumDeclsDeserialized 502245 264092 -238153 -47.42
ReactiveCocoa.AST.NumTotalClangImportedEntities 101738 53368 -48370 -47.54
ReactiveCocoa.AST.NumImportedExternalDefinitions 34112 17756 -16356 -47.95
ReactiveCocoa.AST.NumLoadedModules 3536 1836 -1700 -48.08
ReactiveCocoa.IRModule.NumIRFunctions 6982 3594 -3388 -48.52
ReactiveCocoa.Sema.NumGenericSignatureBuilders 49758 25498 -24260 -48.76
ReactiveCocoa.IRModule.NumIRBasicBlocks 11772 5780 -5992 -50.9
ReactiveCocoa.SILModule.NumSILOptFunctions 4068 1995 -2073 -50.96
ReactiveCocoa.Sema.NumLazyIterableDeclContexts 111342 54383 -56959 -51.16
ReactiveCocoa.AST.NumUsedConformances 704 338 -366 -51.99
ReactiveCocoa.Sema.NumLazyGenericEnvironmentsLoaded 10792 5058 -5734 -53.13
ReactiveCocoa.SILModule.NumSILGenFunctions 2904 1312 -1592 -54.82
ReactiveCocoa.IRModule.NumIRInsts 100599 45126 -55473 -55.14
ReactiveCocoa.Sema.NumTypesValidated 48832 21900 -26932 -55.15
ReactiveCocoa.Sema.NumDeclsValidated 106644 43836 -62808 -58.9
ReactiveCocoa.Sema.NumConstraintScopes 42990 15879 -27111 -63.06
ReactiveSwift.Sema.NumLazyGenericEnvironmentsLoaded 7874 1562 -6312 -80.16
ReactiveCocoa.Sema.NumConformancesDeserialized 115943 19299 -96644 -83.35
ReactiveSwift.Sema.NumTypesDeserialized 256534 19204 -237330 -92.51
ReactiveSwift.Sema.NumDeclsDeserialized 294906 18145 -276761 -93.85
ReactiveSwift.Sema.NumLazyGenericEnvironments 49690 2898 -46792 -94.17
ReactiveSwift.AST.NumLoadedModules 880 40 -840 -95.45
ReactiveSwift.Sema.NumLazyIterableDeclContexts 39950 1572 -38378 -96.07
ReactiveSwift.SILModule.NumSILOptFunctions 6970 226 -6744 -96.76
ReactiveSwift.AST.NumTotalClangImportedEntities 24800 754 -24046 -96.96
ReactiveSwift.Sema.NumGenericSignatureBuilders 31212 868 -30344 -97.22
ReactiveSwift.Sema.NumConformancesDeserialized 88500 1596 -86904 -98.2
ReactiveSwift.AST.NumImportedExternalDefinitions 6446 0 -6446 -100.0
ReactiveSwift.AST.NumUsedConformances 730 0 -730 -100.0
ReactiveSwift.IRModule.NumIRBasicBlocks 21772 0 -21772 -100.0
ReactiveSwift.IRModule.NumIRFunctions 10821 0 -10821 -100.0
ReactiveSwift.IRModule.NumIRGlobals 10934 0 -10934 -100.0
ReactiveSwift.IRModule.NumIRInsts 326029 0 -326029 -100.0
ReactiveSwift.IRModule.NumIRValueSymbols 18075 0 -18075 -100.0
ReactiveSwift.LLVM.NumLLVMBytesOutput 8054228 0 -8054228 -100.0
ReactiveSwift.SILModule.NumSILGenFunctions 4833 0 -4833 -100.0
ReactiveSwift.Sema.NumConstraintScopes 41650 0 -41650 -100.0
ReactiveSwift.Sema.NumDeclsValidated 75348 0 -75348 -100.0
ReactiveSwift.Sema.NumFunctionsTypechecked 4538 0 -4538 -100.0
ReactiveSwift.Sema.NumTypesValidated 100510 0 -100510 -100.0

PR vs. baseline, changed timers (debug)

name old new delta delta_pct

Debug-opt

PR vs. head (debug-opt)

PR vs. head, changed counters (debug-opt)

name old new delta delta_pct
Kingfisher.Driver.ChildrenMaxRSS 407941120 435994624 28053504 6.88
ReactiveSwift.Driver.ChildrenMaxRSS 298233856 313647104 15413248 5.17
Result.Driver.ChildrenMaxRSS 234262528 237678592 3416064 1.46
Result.AST.NumSourceLinesPerSecond 325 327 2 0.62
Alamofire.Driver.ChildrenMaxRSS 194334720 195362816 1028096 0.53
ReactiveCocoa.AST.NumASTBytesAllocated 312291066 312323701 32635 0.01
Kingfisher.AST.NumASTBytesAllocated 289141557 289098037 -43520 -0.02
ReactiveCocoa.Driver.ChildrenMaxRSS 298872832 298790912 -81920 -0.03
ReactiveCocoa.AST.NumSourceLinesPerSecond 5076 5066 -10 -0.2
Kingfisher.AST.NumSourceLinesPerSecond 5595 5555 -40 -0.71
Alamofire.AST.NumSourceLinesPerSecond 3347 3164 -183 -5.47

PR vs. head, changed timers (debug-opt)

name old new delta delta_pct

PR vs. baseline (debug-opt)

PR vs. baseline, changed counters (debug-opt)

No analysis available

PR vs. baseline, changed timers (debug-opt)

No analysis available

Wmo-onone

PR vs. head (wmo-onone)

PR vs. head, changed counters (wmo-onone)

name old new delta delta_pct
ReactiveSwift.Driver.ChildrenMaxRSS 546844672 561119232 14274560 2.61
Result.Driver.ChildrenMaxRSS 254476288 258965504 4489216 1.76
Alamofire.Driver.ChildrenMaxRSS 336408576 340054016 3645440 1.08
ReactiveSwift.AST.NumSourceLinesPerSecond 2886 2902 16 0.55
Kingfisher.Driver.ChildrenMaxRSS 617648128 620351488 2703360 0.44
Result.AST.NumSourceLinesPerSecond 531 533 2 0.38
Kingfisher.AST.NumSourceLinesPerSecond 1374 1379 5 0.36
Alamofire.AST.NumSourceLinesPerSecond 938 940 2 0.21
ReactiveCocoa.AST.NumSourceLinesPerSecond 1215 1209 -6 -0.49
ReactiveCocoa.Driver.ChildrenMaxRSS 520900608 517533696 -3366912 -0.65

PR vs. head, changed timers (wmo-onone)

name old new delta delta_pct

PR vs. baseline (wmo-onone)

PR vs. baseline, changed counters (wmo-onone)

name old new delta delta_pct
Alamofire.AST.NumUsedConformances 0 436 436 100.0
Alamofire.IRModule.NumIRBasicBlocks 0 14093 14093 100.0
Alamofire.IRModule.NumIRFunctions 0 5113 5113 100.0
Alamofire.IRModule.NumIRGlobals 0 4605 4605 100.0
Alamofire.IRModule.NumIRInsts 0 130883 130883 100.0
Alamofire.IRModule.NumIRValueSymbols 0 8385 8385 100.0
Alamofire.LLVM.NumLLVMBytesOutput 0 3080020 3080020 100.0
Kingfisher.AST.NumUsedConformances 0 858 858 100.0
Kingfisher.IRModule.NumIRBasicBlocks 0 17939 17939 100.0
Kingfisher.IRModule.NumIRFunctions 0 7564 7564 100.0
Kingfisher.IRModule.NumIRGlobals 0 8967 8967 100.0
Kingfisher.IRModule.NumIRInsts 0 182871 182871 100.0
Kingfisher.IRModule.NumIRValueSymbols 0 14654 14654 100.0
Kingfisher.LLVM.NumLLVMBytesOutput 0 5111952 5111952 100.0
ReactiveCocoa.AST.NumUsedConformances 0 704 704 100.0
ReactiveCocoa.IRModule.NumIRBasicBlocks 0 10243 10243 100.0
ReactiveCocoa.IRModule.NumIRFunctions 0 6630 6630 100.0
ReactiveCocoa.IRModule.NumIRGlobals 0 9288 9288 100.0
ReactiveCocoa.IRModule.NumIRInsts 0 94342 94342 100.0
ReactiveCocoa.IRModule.NumIRValueSymbols 0 14444 14444 100.0
ReactiveCocoa.LLVM.NumLLVMBytesOutput 0 8889496 8889496 100.0
ReactiveSwift.AST.NumUsedConformances 0 736 736 100.0
ReactiveSwift.IRModule.NumIRBasicBlocks 0 19020 19020 100.0
ReactiveSwift.IRModule.NumIRFunctions 0 10461 10461 100.0
ReactiveSwift.IRModule.NumIRGlobals 0 12284 12284 100.0
ReactiveSwift.IRModule.NumIRInsts 0 312098 312098 100.0
ReactiveSwift.IRModule.NumIRValueSymbols 0 20223 20223 100.0
ReactiveSwift.LLVM.NumLLVMBytesOutput 0 8386724 8386724 100.0
Kingfisher.Driver.ChildrenMaxRSS 469618688 620351488 150732800 32.1
Alamofire.Driver.ChildrenMaxRSS 270950400 340054016 69103616 25.5
ReactiveSwift.Driver.ChildrenMaxRSS 451407872 561119232 109711360 24.3
ReactiveCocoa.Driver.ChildrenMaxRSS 432025600 517533696 85508096 19.79
Alamofire.AST.NumTotalClangImportedEntities 2774 3069 295 10.63
Kingfisher.AST.NumTotalClangImportedEntities 8884 9538 654 7.36
Kingfisher.Sema.NumConstraintScopes 282182 301076 18894 6.7
ReactiveCocoa.AST.NumTotalClangImportedEntities 7088 7258 170 2.4
Alamofire.Sema.NumGenericSignatureBuilders 1528 1546 18 1.18
Kingfisher.Sema.NumGenericSignatureBuilders 3834 3864 30 0.78
ReactiveCocoa.Sema.NumGenericSignatureBuilders 3534 3556 22 0.62
ReactiveSwift.Sema.NumGenericSignatureBuilders 4280 4298 18 0.42
Kingfisher.AST.NumImportedExternalDefinitions 3372 3368 -4 -0.12
ReactiveSwift.SILModule.NumSILGenFunctions 3763 3757 -6 -0.16
Alamofire.AST.NumImportedExternalDefinitions 883 881 -2 -0.23
ReactiveSwift.Sema.NumFunctionsTypechecked 1990 1976 -14 -0.7
Alamofire.SILModule.NumSILGenFunctions 1948 1933 -15 -0.77
ReactiveSwift.SILModule.NumSILOptFunctions 4342 4292 -50 -1.15
Kingfisher.Sema.NumLazyGenericEnvironments 4768 4710 -58 -1.22
Kingfisher.SILModule.NumSILGenFunctions 3186 3146 -40 -1.26
ReactiveSwift.Sema.NumLazyGenericEnvironments 4622 4558 -64 -1.38
Kingfisher.Sema.NumDeclsDeserialized 42943 42329 -614 -1.43
ReactiveCocoa.Sema.NumLazyGenericEnvironments 5924 5832 -92 -1.55
Alamofire.Sema.NumLazyGenericEnvironments 2454 2415 -39 -1.59
Alamofire.Sema.NumDeclsDeserialized 20724 20347 -377 -1.82
ReactiveCocoa.Sema.NumDeclsDeserialized 41130 40354 -776 -1.89
Kingfisher.Sema.NumTypesDeserialized 35018 34278 -740 -2.11
Alamofire.SILModule.NumSILOptFunctions 2206 2157 -49 -2.22
ReactiveSwift.Sema.NumDeclsDeserialized 37374 36516 -858 -2.3
Alamofire.Sema.NumTypesDeserialized 17157 16756 -401 -2.34
Kingfisher.SILModule.NumSILOptFunctions 4252 4152 -100 -2.35
ReactiveCocoa.Sema.NumTypesDeserialized 35673 34834 -839 -2.35
ReactiveCocoa.Sema.NumLazyIterableDeclContexts 3850 3750 -100 -2.6
ReactiveSwift.Sema.NumTypesValidated 26292 25590 -702 -2.67
ReactiveSwift.Sema.NumTypesDeserialized 31307 30324 -983 -3.14
Kingfisher.Sema.NumLazyIterableDeclContexts 3602 3480 -122 -3.39
ReactiveCocoa.SILModule.NumSILGenFunctions 1985 1917 -68 -3.43
Alamofire.Sema.NumLazyIterableDeclContexts 1672 1609 -63 -3.77
Alamofire.Sema.NumLazyGenericEnvironmentsLoaded 365 349 -16 -4.38
ReactiveCocoa.SILModule.NumSILOptFunctions 2405 2292 -113 -4.7
ReactiveSwift.Sema.NumLazyGenericEnvironmentsLoaded 866 824 -42 -4.85
ReactiveSwift.Sema.NumLazyIterableDeclContexts 2924 2778 -146 -4.99
Kingfisher.Sema.NumLazyGenericEnvironmentsLoaded 840 798 -42 -5.0
Alamofire.Sema.NumConstraintScopes 38683 36256 -2427 -6.27
ReactiveSwift.Sema.NumConstraintScopes 38598 35920 -2678 -6.94
ReactiveCocoa.Sema.NumLazyGenericEnvironmentsLoaded 734 676 -58 -7.9
ReactiveCocoa.Sema.NumConstraintScopes 23810 21222 -2588 -10.87
ReactiveSwift.Sema.NumConformancesDeserialized 22922 19708 -3214 -14.02
ReactiveSwift.AST.NumImportedExternalDefinitions 596 512 -84 -14.09
Kingfisher.Sema.NumConformancesDeserialized 24122 20436 -3686 -15.28
Alamofire.Sema.NumConformancesDeserialized 11914 9947 -1967 -16.51
ReactiveCocoa.Sema.NumConformancesDeserialized 18306 15206 -3100 -16.93
Alamofire.Sema.NumTypesValidated 1973 1629 -344 -17.44
Kingfisher.Sema.NumTypesValidated 3756 3046 -710 -18.9
ReactiveSwift.AST.NumTotalClangImportedEntities 2240 1658 -582 -25.98
ReactiveCocoa.Sema.NumTypesValidated 4034 2570 -1464 -36.29
ReactiveCocoa.Sema.NumDeclsValidated 20206 10966 -9240 -45.73
Kingfisher.Sema.NumDeclsValidated 35702 14416 -21286 -59.62
Alamofire.Sema.NumDeclsValidated 17283 6831 -10452 -60.48
ReactiveSwift.Sema.NumDeclsValidated 28656 9610 -19046 -66.46

PR vs. baseline, changed timers (wmo-onone)

name old new delta delta_pct

Release

PR vs. head (release)

PR vs. head, changed counters (release)

name old new delta delta_pct
Kingfisher.AST.NumSourceLinesPerSecond 511 540 29 5.68
ReactiveCocoa.Driver.ChildrenMaxRSS 569352192 583536640 14184448 2.49
Alamofire.AST.NumSourceLinesPerSecond 336 339 3 0.89
ReactiveSwift.Driver.ChildrenMaxRSS 706715648 709218304 2502656 0.35
Result.AST.NumSourceLinesPerSecond 298 299 1 0.34
Kingfisher.Driver.ChildrenMaxRSS 762556416 762462208 -94208 -0.01
ReactiveCocoa.AST.NumSourceLinesPerSecond 524 523 -1 -0.19
ReactiveSwift.AST.NumSourceLinesPerSecond 882 875 -7 -0.79
Result.Driver.ChildrenMaxRSS 299790336 297234432 -2555904 -0.85
Alamofire.Driver.ChildrenMaxRSS 430129152 412729344 -17399808 -4.05

PR vs. head, changed timers (release)

name old new delta delta_pct

PR vs. baseline (release)

PR vs. baseline, changed counters (release)

name old new delta delta_pct
Alamofire.AST.NumUsedConformances 0 436 436 100.0
Alamofire.IRModule.NumIRBasicBlocks 0 15826 15826 100.0
Alamofire.IRModule.NumIRFunctions 0 3616 3616 100.0
Alamofire.IRModule.NumIRGlobals 0 4527 4527 100.0
Alamofire.IRModule.NumIRInsts 0 117715 117715 100.0
Alamofire.IRModule.NumIRValueSymbols 0 7011 7011 100.0
Alamofire.LLVM.NumLLVMBytesOutput 0 3369960 3369960 100.0
Kingfisher.AST.NumUsedConformances 0 858 858 100.0
Kingfisher.IRModule.NumIRBasicBlocks 0 22773 22773 100.0
Kingfisher.IRModule.NumIRFunctions 0 5809 5809 100.0
Kingfisher.IRModule.NumIRGlobals 0 8680 8680 100.0
Kingfisher.IRModule.NumIRInsts 0 170817 170817 100.0
Kingfisher.IRModule.NumIRValueSymbols 0 12885 12885 100.0
Kingfisher.LLVM.NumLLVMBytesOutput 0 5802768 5802768 100.0
ReactiveCocoa.AST.NumUsedConformances 0 704 704 100.0
ReactiveCocoa.IRModule.NumIRBasicBlocks 0 8765 8765 100.0
ReactiveCocoa.IRModule.NumIRFunctions 0 4872 4872 100.0
ReactiveCocoa.IRModule.NumIRGlobals 0 8506 8506 100.0
ReactiveCocoa.IRModule.NumIRInsts 0 66760 66760 100.0
ReactiveCocoa.IRModule.NumIRValueSymbols 0 12112 12112 100.0
ReactiveCocoa.LLVM.NumLLVMBytesOutput 0 8761360 8761360 100.0
ReactiveSwift.AST.NumUsedConformances 0 736 736 100.0
ReactiveSwift.IRModule.NumIRBasicBlocks 0 22135 22135 100.0
ReactiveSwift.IRModule.NumIRFunctions 0 10256 10256 100.0
ReactiveSwift.IRModule.NumIRGlobals 0 11762 11762 100.0
ReactiveSwift.IRModule.NumIRInsts 0 262613 262613 100.0
ReactiveSwift.IRModule.NumIRValueSymbols 0 19698 19698 100.0
ReactiveSwift.LLVM.NumLLVMBytesOutput 0 9845512 9845512 100.0
Alamofire.AST.NumTotalClangImportedEntities 2918 3240 322 11.03
Kingfisher.Driver.ChildrenMaxRSS 701317120 762462208 61145088 8.72
ReactiveCocoa.Driver.ChildrenMaxRSS 540602368 583536640 42934272 7.94
Kingfisher.AST.NumTotalClangImportedEntities 9088 9788 700 7.7
ReactiveSwift.Driver.ChildrenMaxRSS 660402176 709218304 48816128 7.39
Kingfisher.Sema.NumConstraintScopes 282182 301076 18894 6.7
Alamofire.Driver.ChildrenMaxRSS 395132928 412729344 17596416 4.45
ReactiveCocoa.AST.NumTotalClangImportedEntities 7264 7434 170 2.34
Alamofire.Sema.NumGenericSignatureBuilders 1595 1612 17 1.07
ReactiveCocoa.Sema.NumGenericSignatureBuilders 3612 3642 30 0.83
Kingfisher.Sema.NumGenericSignatureBuilders 3925 3947 22 0.56
ReactiveSwift.SILModule.NumSILGenFunctions 3755 3757 2 0.05
Alamofire.SILModule.NumSILGenFunctions 1861 1860 -1 -0.05
ReactiveSwift.Sema.NumGenericSignatureBuilders 4390 4386 -4 -0.09
ReactiveCocoa.SILModule.NumSILGenFunctions 1917 1915 -2 -0.1
Kingfisher.AST.NumImportedExternalDefinitions 3372 3368 -4 -0.12
Alamofire.AST.NumImportedExternalDefinitions 883 881 -2 -0.23
ReactiveSwift.Sema.NumLazyGenericEnvironments 5068 5038 -30 -0.59
ReactiveSwift.Sema.NumFunctionsTypechecked 1990 1976 -14 -0.7
Kingfisher.Sema.NumDeclsDeserialized 48862 48406 -456 -0.93
Kingfisher.Sema.NumLazyGenericEnvironments 5036 4982 -54 -1.07
Alamofire.SILModule.NumSILOptFunctions 2984 2948 -36 -1.21
ReactiveCocoa.Sema.NumLazyGenericEnvironments 6122 6048 -74 -1.21
Alamofire.Sema.NumLazyGenericEnvironments 2741 2706 -35 -1.28
ReactiveSwift.SILModule.NumSILOptFunctions 6852 6762 -90 -1.31
ReactiveCocoa.Sema.NumDeclsDeserialized 42755 42070 -685 -1.6
Alamofire.Sema.NumDeclsDeserialized 24763 24340 -423 -1.71
ReactiveCocoa.Sema.NumTypesDeserialized 39816 39136 -680 -1.71
ReactiveSwift.Sema.NumDeclsDeserialized 44912 44132 -780 -1.74
Kingfisher.SILModule.NumSILOptFunctions 5715 5608 -107 -1.87
Kingfisher.Sema.NumTypesDeserialized 46220 45297 -923 -2.0
Alamofire.Sema.NumTypesDeserialized 23772 23262 -510 -2.15
ReactiveCocoa.SILModule.NumSILOptFunctions 2915 2849 -66 -2.26
ReactiveSwift.Sema.NumTypesDeserialized 41015 40045 -970 -2.36
ReactiveCocoa.Sema.NumLazyIterableDeclContexts 3896 3794 -102 -2.62
ReactiveSwift.Sema.NumTypesValidated 26292 25590 -702 -2.67
Kingfisher.Sema.NumLazyIterableDeclContexts 3664 3541 -123 -3.36
Alamofire.Sema.NumLazyIterableDeclContexts 1724 1663 -61 -3.54
ReactiveSwift.Sema.NumLazyIterableDeclContexts 3012 2871 -141 -4.68
ReactiveSwift.Sema.NumLazyGenericEnvironmentsLoaded 898 850 -48 -5.35
Alamofire.Sema.NumLazyGenericEnvironmentsLoaded 385 364 -21 -5.45
Kingfisher.Sema.NumLazyGenericEnvironmentsLoaded 882 830 -52 -5.9
Alamofire.Sema.NumConstraintScopes 38683 36256 -2427 -6.27
ReactiveSwift.Sema.NumConstraintScopes 38598 35920 -2678 -6.94
ReactiveCocoa.Sema.NumLazyGenericEnvironmentsLoaded 756 686 -70 -9.26
ReactiveSwift.Sema.NumConformancesDeserialized 30973 27855 -3118 -10.07
ReactiveCocoa.Sema.NumConstraintScopes 23810 21222 -2588 -10.87
Kingfisher.Sema.NumConformancesDeserialized 35107 31233 -3874 -11.03
Alamofire.Sema.NumConformancesDeserialized 18728 16570 -2158 -11.52
ReactiveCocoa.Sema.NumConformancesDeserialized 24520 21416 -3104 -12.66
ReactiveSwift.AST.NumImportedExternalDefinitions 596 512 -84 -14.09
Alamofire.Sema.NumTypesValidated 1973 1629 -344 -17.44
Kingfisher.Sema.NumTypesValidated 3756 3046 -710 -18.9
ReactiveSwift.AST.NumTotalClangImportedEntities 2674 2114 -560 -20.94
ReactiveCocoa.Sema.NumTypesValidated 4034 2570 -1464 -36.29
ReactiveCocoa.Sema.NumDeclsValidated 20206 10966 -9240 -45.73
Kingfisher.Sema.NumDeclsValidated 35702 14416 -21286 -59.62
Alamofire.Sema.NumDeclsValidated 17283 6831 -10452 -60.48
ReactiveSwift.Sema.NumDeclsValidated 28656 9610 -19046 -66.46

PR vs. baseline, changed timers (release)

name old new delta delta_pct
Last baseline commit on smoketest-master-debug.csv 
commit 4de0b8570ecc3a81748350219435c85f1060ac16
Author: Graydon Hoare 
Date:   Tue Sep 19 00:18:10 2017 -0700

    Add smoketest cperf-baselines for Xcode 9.0 GM 9A235

No baseline file smoketest-master-debug-opt.csv foundLast baseline commit on smoketest-master-wmo-onone.csv

commit 4de0b8570ecc3a81748350219435c85f1060ac16
Author: Graydon Hoare 
Date:   Tue Sep 19 00:18:10 2017 -0700

    Add smoketest cperf-baselines for Xcode 9.0 GM 9A235

Last baseline commit on smoketest-master-release.csv

commit 4de0b8570ecc3a81748350219435c85f1060ac16
Author: Graydon Hoare 
Date:   Tue Sep 19 00:18:10 2017 -0700

    Add smoketest cperf-baselines for Xcode 9.0 GM 9A235

@rudkx rudkx merged commit 5352d64 into swiftlang:master Sep 25, 2017
@rudkx rudkx deleted the join branch September 25, 2017 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rudkx @swift-ci