[Type checker] Don't create new generic signature builders for known signatures #12091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When type-checking a function or subscript that itself does not have generic parameters (but is within a generic context), we were creating a generic signature builder which will always produce the same generic signature as the enclosing context. Stop creating that generic signature builder. Instead, teach the CompleteGenericTypeResolver to use the generic signature + the canonical generic signature builder for that signature to resolve types, which also eliminates some extraneous re-type-checking. Improves type-checking performance of the standard library by 36%.
…ype. An unconstrained extension will always have the same generic signature as the nominal type it extends. Rather can constructing a new generic signature builder to tell us that, just re-use the generic signature. Improves type-checking performance of the standard library by 15%.
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop creating new GSBs when the generic signature is always known a priori, i.e.,