Recommit benchmark changes with precondition #12092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that we have a precondition implementation both when building in tree and out of tree.
…chmark builds, which is used by some bots" This reverts commit db21063.
|
@swift-ci clean smoke test |
|
I just double checked. I am able to build externally with this. As a bonus, I implemented support in a subsequent commit to enable build-script to build an external benchmark suite to ease testing that code path (i.e. to test it I just pass an arg to build-script rather than rolling my own). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some cleanups that I committed that were reverted since we do not have a precondition when building standalone.