Fix multisource benchmarks #12117
Merged
Fix multisource benchmarks #12117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts to look up sources.
This solves problems relating to the SOURCES variable not finding anything
files. module_name expanded to nothing so:
${${module_name}_sources} -> ${_sources} -> ''
Now we handle this properly.
rdar://34556274
…ark. This will enable us to at least validate on swift.org that the multisource benchmark stuff is working. rdar://34556274
|
@swift-ci smoke test and mergec |
|
@swift-ci smoke test linux platform |
|
Linux test timed out for some reason. |
|
@swift-ci smoke test linux platform |
|
Linux failed again. Due to a CI issue. |
|
@swift-ci smoke test linux platform |
|
Merged to unblock CI testing. |
|
Thanks Mishal! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes multisource benchmarks and converts the single-source benchmark Prims into a multi-source test called PrimsSplit to ensure that there is at least 1 multi-source benchmark.
rdar://34556274