[overlay] Fix Foundation extensions to Substring #12151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
phausler
approved these changes
Sep 28, 2017
|
We should also merge this back to swift-corelibs-foundation as well |
|
@phausler I am going to do this once this gets merged. |
When a substring gets bridged to NSString, it loses the initial offset, therefore APIs that accept or return StringIndex ranges should handle this case explicitly by adding/subtracting the substring start offset. Fixes <rdar://problem/33873277>
moiseev
force-pushed
the
ns-substring
branch
from
05cecc3 to
7322b63
Compare
|
@swift-ci Please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a substring gets bridged to NSString, it loses the initial offset,
therefore APIs that accept or return StringIndex ranges should handle
this case explicitly by adding/subtracting the substring start offset.
Fixes rdar://problem/33873277