Revamped argument parsing unit-tests #12157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rostepher
force-pushed
the
arguments-make-me-testy
branch
from
e7f9c83 to
7adccdf
Compare
|
@swift-ci please smoke test |
Rostepher
force-pushed
the
arguments-make-me-testy
branch
from
7adccdf to
195d4f6
Compare
|
@swift-ci please smoke test |
… of Option classes and included a new test for exhaustiveness which should assure that we are always testing every possible option available in the parser.
… to make the test suite more portable since the original hard-coded values were gathered from my development machine.
Rostepher
force-pushed
the
arguments-make-me-testy
branch
from
195d4f6 to
36c3f47
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR revamps the current argument parsing test suite to use a more declarative (and concise) set of
*Optionclasses in addition to better refining the current behavior of each flag. I've also taken the liberty to add two new test cases that check the exhaustiveness of the generated option unit-tests. The first will ensure that the suite has a test case for every option supported by the argument parser, while the second test ensures that every option has an associated default value.A note for reviewers the first commit does move some classes and definitions around which makes the changes a little noisy.