-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[benchmark] Only add -external suffix to targets in standalone builds where SWIFT_BENCHMARK_SUBCMAKE_BUILD is set. #12208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gottesmm
merged 1 commit into
swiftlang:master
from
gottesmm:pr-d7a43e8fc00361e35ead91db5b65290ee5091091
Oct 1, 2017
Merged
[benchmark] Only add -external suffix to targets in standalone builds where SWIFT_BENCHMARK_SUBCMAKE_BUILD is set. #12208
gottesmm
merged 1 commit into
swiftlang:master
from
gottesmm:pr-d7a43e8fc00361e35ead91db5b65290ee5091091
Oct 1, 2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… where SWIFT_BENCHMARK_SUBCMAKE_BUILD is set. This enables us to distinguish in between builds which are triggered by a subcmake call from the main swift cmake file and one from a user who is trying to compile the swift benchmark suite against a misc swift installation/use the ninja file by hand.
@swift-ci smoke test |
@swift-ci smoke benchmark |
Build comment file:Optimized (O)Improvement (1)
No Changes (328)
Unoptimized (Onone)Regression (1)
No Changes (328)
Hardware Overview
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[benchmark] Only add -external suffix to targets in standalone builds where SWIFT_BENCHMARK_SUBCMAKE_BUILD is set.
This enables us to distinguish in between builds which are triggered by a
subcmake call from the main swift cmake file and one from a user who is trying
to compile the swift benchmark suite against a misc swift installation/use the
ninja file by hand.