[4.0][migrator] When renaming a function decl, we should use underscore to represent empty external argument label. rdar://34569243 #12225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… represent empty external argument label. rdar://34569243 (#12221)
|
@swift-ci please test |
|
Build failed |
|
@swift-ci Please clean test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: We recently changed DeclNameView to return an empty string instead of an underscore to represent an empty argument label. This leads to migration errors when we use the representation literally. This fix teaches migrator to use underscore when emitting rename changes.
Scope: Swift 4.0 Migrator
Radar: rdar://problem/34569243
Risk: Very low
Testing: Regression test added