Stats output dir filename issues #12257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing cases of very long input pathnames to be mangled into stats filenames greater than 255 characters long, which in turn meant stats files were not being written in some cases.
|
@swift-ci please test and merge |
|
@swift-ci please test Linux platform |
|
Build failed |
|
@swift-ci please clean test Linux platform |
jrose-apple
reviewed
Oct 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Principal fix here is to only use the basename of a path when mangling input names into stats-dir
output filenames, so that we are much less likely to hit a path-name limit and drop a stats output
on the floor (this was happening in practice in CI).
Secondary fix is just a harmless-but-silly typo I noticed while in there.