[Driver] Remove unused input type code (NFCI) #12263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We generally don't put bug numbers in the code, partially because a number of them would be Radar URLs. If there's an actual issue report we probably don't need the FIXME. (In most cases a FIXME probably isn't well-specified enough to turn into a report. This one might be.) |
|
The actual simplification looks fine. |
|
Ah OK. Should I remove the FIXME altogether, then? |
|
Yes, sure. |
Summary: When the Swift driver executable was first added in swiftlang@ed20385, the code included a FIXME to support input types, like Clang's `-x <language>` option. Perhaps as a first step in implementing this functionality, it also included dead code that manipulated an input type argument, even though the variable for storing the argument was never written to. Remove the unused input type code, and the FIXME. The FIXME is now tracked with a Swift bug URL, so that a discussion on next steps can be had: https://bugs.swift.org/browse/SR-6054 Test plan: `utils/build-script --release --test`
modocache
force-pushed
the
remove-old-input-type-arg-code-and-fixme
branch
from
58c31dc to
3f8e808
Compare
|
Done! @swift-ci please smoke test and merge |
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When the Swift driver executable was first added in ed20385, the code included a FIXME to support input types, like Clang's
-x <language>option. Perhaps as a first step in implementing this functionality, it also included dead code that manipulated an input type argument, even though the variable for storing the argument was never written to.Remove the unused input type code, and update the FIXME with a Swift bug URL, so that a discussion on next steps can be had.
Test plan:
utils/build-script --release --test