Fold dynamic_method into objc_method #12265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
This will allow us to remove dynamic_method, emitting objc_method in its place. It will also allow objc_method to be used for Objective-C protocol method calls, with witness_method used for Swift native protocol method calls only.
slavapestov
force-pushed
the
sil-dynamic-method
branch
from
97a0349 to
514aa99
Compare
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
1 similar comment
|
@swift-ci Please test source compatibility |
|
SwiftyJSON is using /Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite/project_cache/Kitura/.build/checkouts/SwiftyJSON.git--6955445084174387031/Source/SwiftyJSON.swift:406:26: error: use of undeclared type '_Incrementable' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #12260. Since
dynamic_methodandobjc_methodnow have the same IRGen lowering; the only difference remaining is SIL verifier invariants. We can merge the SIL verifier checks together and removedynamic_methodaltogether.The next step here is to refactor SILGen to use
objc_methodfor Objective-C protocol method calls as well, removing the volatile bit fromwitness_methodand simplifying its IRGen lowering.