[AST] Strip InOutType when cloning a parameter. #12271
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rdar://problem/34789779, where initializer inheritance was breaking in the presence of 'inout' parameters.
|
@swift-ci please smoke test and merge |
CodaFi
reviewed
Oct 4, 2017
| @@ -4197,12 +4197,20 @@ ParamDecl::ParamDecl(Specifier specifier, | |||
| "'var' cannot appear on parameters; you meant 'inout'"); | |||
| } | |||
|
|
|||
| // Remove the top-level inout type, if there is one. | |||
| static Type removeInOutType(Type type) { | |||
There was a problem hiding this comment.
getInOutObjectType() already handles this and I would rather keep usages of getAs<InOutType>() centralized.
There was a problem hiding this comment.
Ugh, how did I miss getInOutObjectType()? Search fail, thank you!
|
In my haste to not get this auto-merged, I busted it. Opened a new PR as #12272 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://problem/34789779, where initializer inheritance was breaking
in the presence of 'inout' parameters.