Skip to content

[code-complete] Update literal protocol to show "" for Character #12293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2017

Conversation

benlangmuir
Copy link
Contributor

... and UnicodeScalar, which is technically more correct than only
showing it for String. This also happens to workaround a bug where we
won't show "" for string.contains.

rdar://problem/34746368

... and UnicodeScalar, which is technically more correct than only
showing it for String.  This also happens to workaround a bug where we
won't show "" for string.contains.

rdar://problem/34746368
@benlangmuir
Copy link
Contributor Author

@swift-ci please smoke test

@benlangmuir benlangmuir requested a review from akyrtzi October 5, 2017 16:56
Copy link
Contributor

@akyrtzi akyrtzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@benlangmuir benlangmuir merged commit 17e14d4 into swiftlang:master Oct 5, 2017
@benlangmuir benlangmuir deleted the cc-string-contains branch October 5, 2017 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants