[Stats] Warn on failure-to-write stats / trace files. #12308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
It's not great because it won't show up in Xcode unless you open the build log, but it's better than nothing. Go for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given recent wild goose chase caused by a failure-to-write files in certain circumstances, I'd like to upgrade this path from silent to noisy failure (though still permitting the compiler to continue).
Plumbing a diagnostic consumer through to here seems to me like a bit of overkill, given it's not a standard operating mode at all -- user has to ask for this and it's a rare use-case -- and there's no source location to complain about; decided to do what LLVM's own stats-reporting does on stats-file-open failure and just write to stderr. Hopefully this is acceptable?