Archetypes now store an interface type #12329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is no longer necessary now that archetypes refer back to a GenericEnvironment.
…ssociatedTypeDecl
Now that archetypes store an interface type, GenericEnvironments no longer need to store a reverse mapping.
…eType::getInterfaceType()
…etInterfaceType()
…e::getInterfaceType()
slavapestov
force-pushed
the
archetype-get-interface-type
branch
from
c2c3c1d to
4bd2b30
Compare
|
@swift-ci Please smoke test |
|
Magnificent! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All ArchetypeTypes are now built by the GSB, which has the original interface type handy. Instead of recording an identifier for primary archetypes and an AssociatedTypeDecl for nested types, just record the interface type instead. This simplifies GenericEnvironment::mapTypeOutOfContext() and allows a few places that passed an archetype to mapTypeOutOfContext() to just do archetype->getInterfaceType() instead.
No change to stdlib compile time, but this eliminates some code.