Implementation of "Restrict cross-module struct initializers to be delegating" #12352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrose-apple
added
the
swift evolution pending discussion
|
Sorry....I can’t do it everything......I don’t know this program.....
네이버 메일앱에서 보냈습니다.-----Original Message-----
보낸사람: "Jordan Rose"<[email protected]>
받는사람: "apple/swift"<[email protected]>
참조: "Subscribed"<[email protected]>
날짜: 2017. 10. 9 오후 5:41:38
제목: [apple/swift] [BLOCKED] Implementation of "Restrict cross-module struct initializers to be delegating" (#12352)
Initial implementation of https://github.com/jrose-apple/swift-evolution/blob/restrict-cross-module-struct-initializers/proposals/nnnn-restrict-cross-module-struct-initializers.md, which I plan to submit for swift-evolution review soon. Slava already had most of this in place as a prototype for the restrictions on what's currently spelled @_fixed_layout. Tidy it up and make it apply all the time across module boundaries.
This doesn't actually work yet because of the FIXMEs in the test cases; it turns out these very cases come up in the overlays. Slava's working on that separately; once that goes in I'll rebase this.
(The tweak in Serialization is because no one had tested -enable-resilience and -enable-testing at the same time. It's a backwards-compatible change, so no need to bump the module format.)
rdar://problem/34777878
You can view, comment on, or merge this pull request online at: #12352
Commit SummaryRestrict cross-module struct initializers to be delegatingFile Changes M include/swift/AST/DiagnosticsSema.def (19) M lib/Sema/ResilienceDiagnostics.cpp (85) M lib/Serialization/Serialization.cpp (2) M test/decl/init/resilience.swift (15) A test/decl/init/resilience_testable.swift (49) Patch Links:#12352
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
jrose-apple
force-pushed
the
restrict-cross-module-struct-initializers
branch
from
9e5579b to
c5ed41a
Compare
Slava already had most of this in place as a prototype for the restrictions on what's currently spelled '@_fixed_layout'. Tidy it up and make it apply all the time across module boundaries. rdar://problem/34777878
jrose-apple
force-pushed
the
restrict-cross-module-struct-initializers
branch
from
c5ed41a to
f175b07
Compare
jrose-apple
changed the title
|
Closing in favor of #12834. |
AnthonyLatsis
removed
the
swift evolution pending discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of https://github.com/jrose-apple/swift-evolution/blob/restrict-cross-module-struct-initializers/proposals/nnnn-restrict-cross-module-struct-initializers.md, which I plan to submit for swift-evolution review soon. Slava already had most of this in place as a prototype for the restrictions on what's currently spelled
@_fixed_layout. Tidy it up and make it apply all the time across module boundaries.This doesn't actually work yet because of the FIXMEs in the test cases; it turns out these very cases come up in the overlays. Slava's working on that separately; once that goes in I'll rebase this.
(The tweak in Serialization is because no one had tested -enable-resilience and -enable-testing at the same time. It's a backwards-compatible change, so no need to bump the module format.)
rdar://problem/34777878