IRGen: fix DLL storage for runtime functions #12353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The runtime functions should not have DLLImport storage for the runtime functions. Without this change, we would see `swift_unexpectedError` be given DLL Import DLL Storage. It should probably be given DLLExport DLL Storage. This is needed to repair the Windows build. The problem is that the ExternalLinkage does not indicate whether the function is internally available or externally available, merely that it participates in linkage resolution. Ensure that we only give import storage to declarations with ExternalLinkage.
|
@swift-ci please test and merge |
|
@swift-ci please clean test Linux platform |
|
Build failed |
|
Please test with following pull request: @swift-ci Please test Linux platform |
|
This change doesn't actually depend on the lib dispatch change. Going to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runtime functions should not have DLLImport storage for the runtime
functions. Without this change, we would see
swift_unexpectedErrorbegiven DLL Import DLL Storage. It should probably be given DLLExport DLL
Storage. This is needed to repair the Windows build. The problem is
that the ExternalLinkage does not indicate whether the function is
internally available or externally available, merely that it
participates in linkage resolution. Ensure that we only give import
storage to declarations with ExternalLinkage.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.