[RemoteAST] Fix function generation to form type from multiple params #12375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @slavapestov @DougGregor that you going to love this one. |
xedin
changed the title
inout params
xedin
force-pushed
the
fix-remote-ast-func-type
branch
from
fd81a6d to
5b59fb4
Compare
If function type has multiple parameters make sure that correct tuple type is formed before constructing function type.
xedin
force-pushed
the
fix-remote-ast-func-type
branch
from
5b59fb4 to
ae5c72e
Compare
|
@swift-ci please smoke test |
|
Oh no :( Can you add a test please? |
|
@slavapestov, I suspect that @xedin might appreciate a pointer to figure out how to write such a test |
|
Yes, I most definitely would appreciate that! :) |
|
@xedin Take a look at test/RemoteAST/structural_types.swift. It already has tests for functions with multiple inputs but since they're materializable it must be going through the one-parameter code path. Try adding a test case for a function with two inout arguments, and see if you can get it to fail before your fix. |
|
Closing this one because the problem is going to be fixed by #12421 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If function type has multiple parameters make sure that correct
tuple type is formed before constructing function type.