[ClangImporter] Handle property with getter that returns instancetype #12414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We just import this as a property, and Swift doesn't support properties with dynamic Self type, even if they are read-only. Don't mark the getter as returning dynamic Self in this case. (This was only a problem in builds with the AST verifier turned on.) https://bugs.swift.org/browse/SR-5684
jrose-apple
force-pushed
the
no-instancetype-for-you
branch
from
ae13b75 to
d56a927
Compare
|
Fixing this sooner rather than later because SwiftPM is running into it. cc @aciidb0mb3r @swift-ci Please test |
|
Thanks a lot @jrose-apple 🎉😱👍 /cc @briancroom |
|
Ah, oops. At one point I did look into making get-only properties support a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We just import this as a property, and Swift doesn't support properties with dynamic Self type, even if they are read-only. Don't mark the getter as returning dynamic Self in this case.
(This was only a problem in builds with the AST verifier turned on.)
SR-5684 / rdar://problem/33897488