[AST] Name lookup shouldn't find pattern declarations later in the same condition. #12438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
StmtCondition but in earlier entries. Fixes SR-4082, SR-4387.
|
Oops, forgot to add the new test. (Added/squashed) |
This was referenced Oct 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the code:
The name lookup of "x" in x > 0 was finding the let pattern declaration after it in the same condition, not the "x" in the previous line. This change disallows finding later patterns when looking up source locations that are earlier in the same condition.
Resolves SR-4082.
Resolves SR-4387.