Add implementation of SE-0185 to CHANGELOG #12447
Conversation
CHANGELOG.md
Outdated
|
|
||
| * [SE-0185][] | ||
|
|
||
| Structs and enums now automatically receive synthesized implementations of `Equatable` and/or `Hashable` if all of their stored members conform to those protocols. You must explicitly declare that the type conforms to `Equatable`/`Hashable` (not in an extension), but the compiler will provide the implementation of `==`/`hashValue` for you if you do not write one yourself. |
There was a problem hiding this comment.
Nitpick: until the second sentence this suggests that the conformance is added automatically. Maybe a better way to phrase it would be "Structs and enums declared a conformance to Equatable/Hashable now get an automatically synthesized implementation of ==/hashValue. For structs, all stored properties must be Equatable/Hashable. For enums, all enum cases with associated values must be Equatable/Hashable".
| Swift 4.1 | ||
| --------- | ||
|
|
||
| * [SE-0185][] |
There was a problem hiding this comment.
I think you need to add the link to the actual proposal elsewhere in the file for this to work
There was a problem hiding this comment.
Much to my surprise, it was already there! (Last line of https://raw.githubusercontent.com/apple/swift/master/CHANGELOG.md.)
CHANGELOG.md
Outdated
| ```swift | ||
| public enum Token: Hashable { | ||
| case comma | ||
| case identifier(String) |
There was a problem hiding this comment.
You can also have a case with a tuple type, right? Might be worth adding an example of that too.
There was a problem hiding this comment.
Not yet, unfortunately. The proposal and implementation only covered types where all stored members strictly conform to the protocol. There's no special handling for tuples yet (I'm happy to work on it as a follow-up).
That also means that the somewhat obvious case of Optional isn't handled yet, either. My hope was that conditional conformances would be a reality in time for this feature to pick it up, but perhaps that should be added as a special case as well in the meantime?
|
@tkremenek What heading should we use for new features that are not in any announced release? |
allevato
force-pushed
the
eq-hash-changelog
branch
from
d812875 to
6260113
Compare
|
@slavapestov use Swift 4.1 |
Since this is the first post-4.0 item in the change log, I wasn't sure if it should be considered Swift 4.1 or something else—let me know if that should change.