[Sema] NFC: Simplify type coercion of ClosureExprs #12468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
davezarzycki
commented
Oct 16, 2017
davezarzycki
commented
- If we have an updatable ClosureExpr, then both fromEI.isAutoClosure() and toEI.isAutoClosure() must be false because the type system ensures that normal closures and functions do not convert to auto-closures.
- If we have a throwing ClosureExpr, then fromEI.throws() and toEI.throws() must be true, otherwise an erroneous throwing to non-throwing closure/function conversions would be possible. From a different perspective, updating the 'throws' bit would make sense if overloading on 'throws' wasn't possible.
* If we have an updatable ClosureExpr, then both fromEI.isAutoClosure() and toEI.isAutoClosure() must be false because the type system ensures that normal closures and functions do not convert to auto-closures. * If we have a throwing ClosureExpr, then fromEI.throws() and toEI.throws() must be true, otherwise an erroneous throwing to non-throwing closure/function conversions would be possible. From a different perspective, updating the 'throws' bit would make sense if overloading on 'throws' wasn't possible.
|
@swift-ci please test |
|
Hi @lattner – Sorry for the stray click that turned into a GitHub review request. Carry on :-) |
DougGregor
approved these changes
Oct 16, 2017
| swift::AnyFunctionType::ExtInfo newEI(fromEI.getRepresentation(), | ||
| toEI.isAutoClosure(), | ||
| toEI.isNoEscape() | fromEI.isNoEscape(), | ||
| toEI.throws() & fromEI.throws()); |
There was a problem hiding this comment.
This is such a weird computation. We take the "autoclosure" bit from the "to" type, "noescape" from either type (even though it's only on the "to" type based on the "if" statement above) and "throws" from both types (which makes no sense).
There was a problem hiding this comment.
Indeed. Don't forget that this goofiness only happened when the no escape bit and only the no escape bit needed propagating. Thanks for the review!
|
nice patch @davezarzycki ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.