SILGen: Fix bug with NSString import-as-member globals #12473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rjmccall Tsk, tsk. ;-) |
|
@swift-ci Please smoke test |
slavapestov
force-pushed
the
import-as-a-crashing-member
branch
from
b31973f to
41dd03d
Compare
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux |
1 similar comment
|
@swift-ci Please smoke test Linux |
|
Can you add a test with a nullable NSString as well? |
|
@jrose-apple a _Nullable NSString still imports as NSString and not "I have a horrible, horrible feeling that this is “by design”" -- @DougGregor I'll add a test for the broken behavior so that we'll know if it ever changes. |
This is not really the right fix if we want to have physically addressed lvalues support bridging in general, but doing so requires adding a new LValue component type and doing a bunch more refactoring, so just hack in a narrow fix for now since it only seems to occur in one case. Fixes <rdar://problem/34913892>.
slavapestov
force-pushed
the
import-as-a-crashing-member
branch
from
41dd03d to
dfdd3a7
Compare
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not really the right fix if we want to have physically
addressed lvalues support bridging in general, but doing so
requires adding a new LValue component type and doing a bunch
more refactoring, so just hack in a narrow fix for now since
it only seems to occur in one case.
Fixes rdar://problem/34913892.