[GSB] Resolve type into an equivalence class without building a new PA. #12477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lized ones. When a conformance can either be synthesized or implied, we tend to prefer implied. However, if the implied conformance comes from a deserialized conformance, it will lead to an incomplete conformance and cause a crash. This is a narrow fix for SR-6105 / rdar://problem/34911378.
…ypes. When we're only resolving the equivalence class in which a dependent type occurs, always use the archetype anchor for the equivalence class to find the equivalence class of the next nested type. This means that, for example, determining the equivalence class of C.SubSequence.SubSequence.SubSequence.SubSequence for a Collection C will only resolve potential archetypes up to C.SubSequence.SubSequence. Not much benefit from this because the GenericSignatureBuilder itself isn't using resolveEquivalenceClass() when expanding requirements.
These properties should be queried on the equivalence class itself.
…ealized. We want to be able to resolve a type to a particular known equivalence class without realizing the corresponding potential archetype. Represent this in ResolveResult, even though we're not using this state yet.
Teach GenericSignatureBuilder::resolveEquivalenceClass() to perform resolution of a type into a dependent type and its equivalence class without realizing that potential archetype. Improves type-checking time for the standard library by ~6%.
|
@swift-ci please smoke test and merge |
Any potential archetype with the lowest depth in the equivalence class will do when we're resolving for equivalence classes, so keep the lowest-depth potential archetype handy.
|
@swift-ci please smoke test and merge |
1 similar comment
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teach
GenericSignatureBuilder::resolveEquivalenceClass()to performresolution of a type into a dependent type and its equivalence class
without realizing that potential archetype. Improves type-checking
time for the standard library by ~6%.