Windows cross compilation #12480
Closed
Windows cross compilation #12480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to read and see what is going on. This made it easier to see what parameters were being passed when debugging the windows cross-compilation dependencies.
Rather than check the two names individually use a `IN_LIST` to make it simpler to reason about. Wrap another conditional to 80-columns. NFC.
|
CC: @llvm-beanz @gottesmm |
|
@swift-ci please test |
|
Build failed |
For the non-MachO targets, which do not have the concept of fat binaries, depend explicitly on the architecture variant. This is particularly useful for Windows which permits cross-compilation and cross-targeting of all the variants even though it does not support fat binaries. This allows us to build a single variant of the windows standard library at a time in the case that we would like to build a subset of the targets.
When building non-MachO targets, there is no support for fat binaries. As a result, the lipo target does nothing. Because we do not support variant builds for ELF targets, this has not resulted in any issues. However, the PE/COFF (Windows) target suppots multiple variants. In such a case, the "lipo" target will copy a number of builds, leaving the binary to be an arbitrary variant. Instead, prefer to always use the architectural variant path. In place, create an empty target which serves as a means of collecting dependencies.
compnerd
force-pushed
the
windows-cross-compilation
branch
from
fe04987 to
ff5d635
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
Rebased and split. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.