Skip to content

[Driver] Fix linker test by preparing empty dir #12518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

modocache
Copy link
Contributor

This fixes an intermittent failure introduced by #12507.

This fixes an intermittent failure introduced by
swiftlang#12507.
@modocache modocache requested a review from jrose-apple October 20, 2017 00:22
@modocache
Copy link
Contributor Author

@swift-ci please smoke test

@gparker42
Copy link
Contributor

We should run empty_directory(%t) at the start and put all of the other intermediate files inside it (%t/simple.txt etc). But this fix is fine to repair the build first.

davidungar pushed a commit to davidungar/swift that referenced this pull request Oct 20, 2017
@modocache modocache merged commit ce153ea into swiftlang:master Oct 20, 2017
@modocache modocache deleted the sr-2660-driver-swiftmodule-linker-inputs branch October 20, 2017 00:55
@modocache
Copy link
Contributor Author

Thanks for the review @gparker42, looks like the tests passed so I'll merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants