-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Swift 4.1 branch #12522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift 4.1 branch #12522
Conversation
Handle function_ref -> convert_function -> thin_to_thick. Fixes <rdar://problem/35059942> Failed - Lark, 3.0, Swift Package - Source Compatibility Suite (master)
@swift-ci smoke test. |
@eeckstein is this the correct way to cherry pick into 4.1, and if so can you approve it so I can merge the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MandatoryInlining changes LGTM.
The IRGen changes should be reviewed by someone else
I'll wait for @shajrawi to review the LoadableAddress changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@swift-ci smoke test and merge. |
Small request: can you title your 4.1 PRs more clearly in the future? I'd like to know what you're doing to the 4.1 branch without having to click into the PR. |
@shahmishal This PR fixes the bots that were already broken at the time the 4.1 branch was cut. I don't know how to get this merged. Is it something you can do? |
This is a functional change, so you'll need CCC review for the 4.1 branch. |
@swift-ci nominate. This does not really need CCC. They are the "emergency" bug fixes for bots that were broken at the time the branch was cut and are completely obvious. I originally didn't intend for anyone else to even look at this PR. But since it took so long for the PR to be merged, we now have an official process. So here goes: Explanation: Same-day fixes for two broken bots at the time the 4.1 branch was cut. Scope: ASAN and source-compatibility tests. Origin: d369aa4 Support @NoEscape SIL function types. (#12420) Radar: Risk: These are minimally invasive surgical fixes. Testing: See scope. |
@swift-ci test source compatibility |
Merge bug fixes into 4.1.