Merge pull request #12484 from shajrawi/relax_verify #12526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relax the open_existential_addr immutable_access verifier further after sil-combine bail-out
shajrawi
force-pushed
the
verifier_fix
branch
from
04aec0c to
845ae79
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
radar rdar://problem/35010515
• Explanation: Found another open_existential_addr immutable_access pattern that got exposed by the new sil-combiner changes
• Scope of Issue: sil-combiner sometimes keeps open_existential_addr immutable_access instructions, we have a new pattern created by an interaction of a few different optimizations: we have an unchecked address cast (devirtualization) + immutable use of that address. Support said pattern in the SIL Verifier.
• Origination: Running an optimized version of the standard tests
• Risk: Low - one line change to Verifier - adds StructElementAddrInst as one of the conditions we bail on.
• Reviewed By: Roman Levenstein