[GSB] Reduce use of potential archetypes when describing constraints #12536

DougGregor · 2017-10-20T23:43:59Z

Start delaying the realization of potential archetypes in a few ways:

Constraint can now store a dependent type that will be lazily (and explicitly) realized to a potential archetype
The RequirementSource APIs traffic mostly in dependent types now

We're still eagerly resolving the subject to a potential archetype everywhere, but this refactoring allows us to start introducing laziness.

…he class. It's getting big, and there will soon be an ordering dependency with FloatingRequirementSource. NFC

Eliminate potential archetypes from most of the public interface of RequirementSource.

…ces. Refactor the interfaces that involve “walking” a requirement source (e.g., minimization, computation of the affected type, etc.) to rely only on interface types and not potential archetypes.

DougGregor · 2017-10-20T23:44:05Z

@swift-ci please smoke test

Eliminates another too-early source of realization of potential archetypes.

…ation.

slavapestov · 2017-10-21T08:51:06Z

include/swift/AST/GenericSignatureBuilder.h

  /// Retrieve the generic signature builder with which this archetype is
  /// associated.
-  /// FIXME: Only EquivalenceClassVizIterator gets to use this.
  GenericSignatureBuilder *getBuilder() const {


So is this still needed?

There are several callers still, but not so many that we can't eliminate their dependence on getBuilder().

sigh, that took longer than expected. It's gone now.

The remaining two uses after this refactor are... stubborn.

…der().

This allows us to eliminate `getBuilder()`.

Now that getBuilder() is gone, stash an ASTContext into root PotentialArchetypes instead of a GenericSignatureBuilder. This eliminates some ickiness where we had to re-root potential archetypes when moving a GenericSignatureBuilder.

DougGregor · 2017-10-23T21:29:56Z

@swift-ci please smoke test

DougGregor · 2017-10-23T21:30:02Z

@swift-ci please test compiler performance

DougGregor · 2017-10-23T21:30:27Z

@swift-ci please smoke test

DougGregor · 2017-10-23T21:30:35Z

@swift-ci please smoke test

DougGregor · 2017-10-23T21:30:57Z

@swift-ci please smoke test

DougGregor · 2017-10-23T21:39:26Z

@swift-ci please test compiler performance

swift-ci · 2017-10-23T22:37:13Z

Build comment file:

Compilation-performance test failed

DougGregor · 2017-10-24T00:46:04Z

@graydon there was a failure with the compiler performance test

DougGregor · 2017-10-24T02:53:34Z

@swift-ci please smoke test compiler performance

DougGregor · 2017-10-24T02:53:50Z

@swift-ci please smoke test compiler performance

swift-ci · 2017-10-24T04:06:02Z

Build comment file:

Summary for master smoketest

Regressions found (see below)

Debug
- PR vs. head (debug)
  - PR vs. head, changed counters (debug)
  - PR vs. head, changed timers (debug)
- PR vs. baseline (debug)
  - PR vs. baseline, changed counters (debug)
  - PR vs. baseline, changed timers (debug)
Release
- PR vs. head (release)
  - PR vs. head, changed counters (release)
  - PR vs. head, changed timers (release)
- PR vs. baseline (release)
  - PR vs. baseline, changed counters (release)
  - PR vs. baseline, changed timers (release)

Debug

PR vs. head (debug)

PR vs. head, changed counters (debug)

Regressed (0)

Improved (0)

Unchanged (abs(delta) < 0.01% or 100000usec) (115)

Unchanged (abs(delta) < 0.01% or 100000usec) in Alamofire (23)

name	old	new	delta_pct
AST.NumImportedExternalDefinitions	5759	5759	0.0%
AST.NumLoadedModules	522	522	0.0%
AST.NumTotalClangImportedEntities	18308	18308	0.0%
AST.NumUsedConformances	432	432	0.0%
IRModule.NumIRBasicBlocks	13594	13594	0.0%
IRModule.NumIRFunctions	5110	5110	0.0%
IRModule.NumIRGlobals	4701	4701	0.0%
IRModule.NumIRInsts	132791	132791	0.0%
IRModule.NumIRValueSymbols	8430	8430	0.0%
LLVM.NumLLVMBytesOutput	3020476	3020476	0.0%
SILModule.NumSILGenFunctions	2458	2458	0.0%
SILModule.NumSILOptFunctions	4648	4648	0.0%
Sema.NumConformancesDeserialized	34077	34077	0.0%
Sema.NumConstraintScopes	39584	39584	0.0%
Sema.NumDeclsDeserialized	193046	193046	0.0%
Sema.NumDeclsValidated	7149	7149	0.0%
Sema.NumFunctionsTypechecked	4054	4054	0.0%
Sema.NumGenericSignatureBuilders	3307	3307	0.0%
Sema.NumLazyGenericEnvironments	30093	30093	0.0%
Sema.NumLazyGenericEnvironmentsLoaded	2495	2495	0.0%
Sema.NumLazyIterableDeclContexts	19120	19120	0.0%
Sema.NumTypesDeserialized	155253	155253	0.0%
Sema.NumTypesValidated	6298	6298	0.0%

Unchanged (abs(delta) < 0.01% or 100000usec) in Kingfisher (23)

name	old	new	delta_pct
AST.NumImportedExternalDefinitions	20266	20266	0.0%
AST.NumLoadedModules	1323	1323	0.0%
AST.NumTotalClangImportedEntities	57132	57132	0.0%
AST.NumUsedConformances	850	850	0.0%
IRModule.NumIRBasicBlocks	17779	17779	0.0%
IRModule.NumIRFunctions	7752	7752	0.0%
IRModule.NumIRGlobals	9063	9063	0.0%
IRModule.NumIRInsts	184365	184365	0.0%
IRModule.NumIRValueSymbols	14452	14452	0.0%
LLVM.NumLLVMBytesOutput	4945460	4945460	0.0%
SILModule.NumSILGenFunctions	4178	4178	0.0%
SILModule.NumSILOptFunctions	8447	8447	0.0%
Sema.NumConformancesDeserialized	64942	64942	0.0%
Sema.NumConstraintScopes	312304	312304	0.0%
Sema.NumDeclsDeserialized	365964	365964	0.0%
Sema.NumDeclsValidated	9338	9338	0.0%
Sema.NumFunctionsTypechecked	12708	12708	0.0%
Sema.NumGenericSignatureBuilders	9644	9644	0.0%
Sema.NumLazyGenericEnvironments	58932	58932	0.0%
Sema.NumLazyGenericEnvironmentsLoaded	5290	5290	0.0%
Sema.NumLazyIterableDeclContexts	49133	49133	0.0%
Sema.NumTypesDeserialized	297416	297416	0.0%
Sema.NumTypesValidated	14298	14298	0.0%

Unchanged (abs(delta) < 0.01% or 100000usec) in ReactiveCocoa (23)

name	old	new	delta_pct
AST.NumImportedExternalDefinitions	38866	38866	0.0%
AST.NumLoadedModules	3536	3536	0.0%
AST.NumTotalClangImportedEntities	110630	110630	0.0%
AST.NumUsedConformances	700	700	0.0%
IRModule.NumIRBasicBlocks	10868	10868	0.0%
IRModule.NumIRFunctions	6914	6914	0.0%
IRModule.NumIRGlobals	9656	9656	0.0%
IRModule.NumIRInsts	98701	98701	0.0%
IRModule.NumIRValueSymbols	14568	14568	0.0%
LLVM.NumLLVMBytesOutput	6509356	6509356	0.0%
SILModule.NumSILGenFunctions	2892	2892	0.0%
SILModule.NumSILOptFunctions	4369	4369	0.0%
Sema.NumConformancesDeserialized	47294	47294	0.0%
Sema.NumConstraintScopes	62158	62158	0.0%
Sema.NumDeclsDeserialized	505307	505307	0.0%
Sema.NumDeclsValidated	4712	4712	0.0%
Sema.NumFunctionsTypechecked	23048	23048	0.0%
Sema.NumGenericSignatureBuilders	23528	23528	0.0%
Sema.NumLazyGenericEnvironments	96090	96090	0.0%
Sema.NumLazyGenericEnvironmentsLoaded	9212	9212	0.0%
Sema.NumLazyIterableDeclContexts	98194	98194	0.0%
Sema.NumTypesDeserialized	437152	437152	0.0%
Sema.NumTypesValidated	34536	34536	0.0%

Unchanged (abs(delta) < 0.01% or 100000usec) in ReactiveSwift (23)

name	old	new	delta_pct
AST.NumImportedExternalDefinitions	3454	3454	0.0%
AST.NumLoadedModules	880	880	0.0%
AST.NumTotalClangImportedEntities	9062	9062	0.0%
AST.NumUsedConformances	724	724	0.0%
IRModule.NumIRBasicBlocks	19130	19130	0.0%
IRModule.NumIRFunctions	10541	10541	0.0%
IRModule.NumIRGlobals	12434	12434	0.0%
IRModule.NumIRInsts	314500	314500	0.0%
IRModule.NumIRValueSymbols	19287	19287	0.0%
LLVM.NumLLVMBytesOutput	8308136	8308136	0.0%
SILModule.NumSILGenFunctions	4813	4813	0.0%
SILModule.NumSILOptFunctions	7705	7705	0.0%
Sema.NumConformancesDeserialized	46804	46804	0.0%
Sema.NumConstraintScopes	36536	36536	0.0%
Sema.NumDeclsDeserialized	268499	268499	0.0%
Sema.NumDeclsValidated	20562	20562	0.0%
Sema.NumFunctionsTypechecked	3532	3532	0.0%
Sema.NumGenericSignatureBuilders	8826	8826	0.0%
Sema.NumLazyGenericEnvironments	47286	47286	0.0%
Sema.NumLazyGenericEnvironmentsLoaded	5932	5932	0.0%
Sema.NumLazyIterableDeclContexts	28270	28270	0.0%
Sema.NumTypesDeserialized	224862	224862	0.0%
Sema.NumTypesValidated	70786	70786	0.0%

Unchanged (abs(delta) < 0.01% or 100000usec) in Result (23)

name	old	new	delta_pct
AST.NumImportedExternalDefinitions	338	338	0.0%
AST.NumLoadedModules	108	108	0.0%
AST.NumTotalClangImportedEntities	1098	1098	0.0%
AST.NumUsedConformances	62	62	0.0%
IRModule.NumIRBasicBlocks	1272	1272	0.0%
IRModule.NumIRFunctions	632	632	0.0%
IRModule.NumIRGlobals	758	758	0.0%
IRModule.NumIRInsts	16546	16546	0.0%
IRModule.NumIRValueSymbols	1172	1172	0.0%
LLVM.NumLLVMBytesOutput	399708	399708	0.0%
SILModule.NumSILGenFunctions	314	314	0.0%
SILModule.NumSILOptFunctions	642	642	0.0%
Sema.NumConformancesDeserialized	1994	1994	0.0%
Sema.NumConstraintScopes	3738	3738	0.0%
Sema.NumDeclsDeserialized	26663	26663	0.0%
Sema.NumDeclsValidated	518	518	0.0%
Sema.NumFunctionsTypechecked	298	298	0.0%
Sema.NumGenericSignatureBuilders	468	468	0.0%
Sema.NumLazyGenericEnvironments	4864	4864	0.0%
Sema.NumLazyGenericEnvironmentsLoaded	486	486	0.0%
Sema.NumLazyIterableDeclContexts	2926	2926	0.0%
Sema.NumTypesDeserialized	22334	22334	0.0%
Sema.NumTypesValidated	1184	1184	0.0%

PR vs. head, changed timers (debug)

Regressed (0)

Improved (0)

Unchanged (abs(delta) < 0.01% or 1000000usec) (9)

Unchanged (abs(delta) < 0.01% or 1000000usec) in Alamofire (1)

name	old	new	delta	delta_pct
time.swift-driver.Alamofire-all-x86_64_apple_macosx10.10-o-Onone.wall	5917931	5914149	-3782	-0.06%

Unchanged (abs(delta) < 0.01% or 1000000usec) in Kingfisher (2)

name	old	new	delta	delta_pct
time.swift-driver.Kingfisher-all-arm64_apple_ios8.0-o-Onone.wall	4878985	4863219	-15766	-0.32%
time.swift-driver.Kingfisher-all-armv7_apple_ios8.0-o-Onone.wall	5097797	5068518	-29279	-0.57%

Unchanged (abs(delta) < 0.01% or 1000000usec) in ReactiveCocoa (2)

name	old	new	delta	delta_pct
time.swift-driver.ReactiveCocoa-all-arm64_apple_ios8.0-o-Onone.wall	3602523	3665871	63348	1.76%
time.swift-driver.ReactiveCocoa-all-armv7_apple_ios8.0-o-Onone.wall	`3676875`	3659975	-16900	-0.46%

Unchanged (abs(delta) < 0.01% or 1000000usec) in ReactiveSwift (2)

name	old	new	delta	delta_pct
time.swift-driver.ReactiveSwift-all-armv7_apple_ios8.0-o-Onone.wall	3698511	3706547	8036	0.22%
time.swift-driver.ReactiveSwift-all-arm64_apple_ios8.0-o-Onone.wall	3600939	3569940	-30999	-0.86%

Unchanged (abs(delta) < 0.01% or 1000000usec) in Result (2)

name	old	new	delta	delta_pct
time.swift-driver.Result-all-armv7_apple_ios8.0-o-Onone.wall	1543091	1533001	-10090	-0.65%
time.swift-driver.Result-all-arm64_apple_ios8.0-o-Onone.wall	1548192	1530282	-17910	-1.16%

PR vs. baseline (debug)

PR vs. baseline, changed counters (debug)

Regressed (18)

Regressed in Alamofire (4)

name	old	new	delta	delta_pct
SILModule.NumSILOptFunctions	3908	4648	740	18.94% ⛔
Sema.NumConformancesDeserialized	31066	34077	3011	9.69% ⛔
Sema.NumLazyGenericEnvironments	29740	30093	353	1.19% ⛔
LLVM.NumLLVMBytesOutput	2995540	3020476	24936	0.83% ⛔

Regressed in Kingfisher (2)

name	old	new	delta	delta_pct
SILModule.NumSILOptFunctions	7512	8447	935	12.45% ⛔
LLVM.NumLLVMBytesOutput	4701704	4945460	243756	5.18% ⛔

Regressed in ReactiveCocoa (9)

name	old	new	delta	delta_pct
Sema.NumConstraintScopes	42990	62158	19168	44.59% ⛔
LLVM.NumLLVMBytesOutput	4775608	6509356	1733748	36.3% ⛔
Sema.NumFunctionsTypechecked	18516	23048	4532	24.48% ⛔
AST.NumImportedExternalDefinitions	34112	38866	4754	13.94% ⛔
AST.NumTotalClangImportedEntities	101754	110630	8876	8.72% ⛔
SILModule.NumSILOptFunctions	4068	4369	301	7.4% ⛔
Sema.NumLazyGenericEnvironments	90692	96090	5398	5.95% ⛔
Sema.NumDeclsDeserialized	494670	505307	10637	2.15% ⛔
IRModule.NumIRGlobals	9536	9656	120	1.26% ⛔

Regressed in ReactiveSwift (3)

name	old	new	delta	delta_pct
SILModule.NumSILOptFunctions	6970	7705	735	10.55% ⛔
LLVM.NumLLVMBytesOutput	8049848	8308136	258288	3.21% ⛔
IRModule.NumIRGlobals	12388	12434	46	0.37% ⛔

Improved (69)

Improved in Alamofire (17)

name	old	new	delta	delta_pct
SILModule.NumSILGenFunctions	2463	2458	-5	-0.2% ✅
AST.NumUsedConformances	435	432	-3	-0.69% ✅
IRModule.NumIRGlobals	4765	4701	-64	-1.34% ✅
Sema.NumTypesDeserialized	158862	155253	-3609	-2.27% ✅
IRModule.NumIRValueSymbols	8767	8430	-337	-3.84% ✅
IRModule.NumIRFunctions	5357	5110	-247	-4.61% ✅
Sema.NumLazyGenericEnvironmentsLoaded	2641	2495	-146	-5.53% ✅
IRModule.NumIRInsts	145724	132791	-12933	-8.87% ✅
Sema.NumConstraintScopes	43672	39584	-4088	-9.36% ✅
IRModule.NumIRBasicBlocks	15117	13594	-1523	-10.07% ✅
Sema.NumLazyIterableDeclContexts	21455	19120	-2335	-10.88% ✅
Sema.NumFunctionsTypechecked	5545	4054	-1491	-26.89% ✅
AST.NumImportedExternalDefinitions	8501	5759	-2742	-32.26% ✅
AST.NumTotalClangImportedEntities	27881	18308	-9573	-34.34% ✅
Sema.NumTypesValidated	18298	6298	-12000	-65.58% ✅
Sema.NumGenericSignatureBuilders	13996	3307	-10689	-76.37% ✅
Sema.NumDeclsValidated	61341	7149	-54192	-88.35% ✅

Improved in Kingfisher (20)

name	old	new	delta	delta_pct
SILModule.NumSILGenFunctions	4186	4178	-8	-0.19% ✅
IRModule.NumIRGlobals	9117	9063	-54	-0.59% ✅
AST.NumUsedConformances	858	850	-8	-0.93% ✅
Sema.NumLazyGenericEnvironmentsLoaded	5480	5290	-190	-3.47% ✅
IRModule.NumIRValueSymbols	14986	14452	-534	-3.56% ✅
IRModule.NumIRInsts	194978	184365	-10613	-5.44% ✅
IRModule.NumIRFunctions	8204	7752	-452	-5.51% ✅
IRModule.NumIRBasicBlocks	18956	17779	-1177	-6.21% ✅
Sema.NumConformancesDeserialized	70852	64942	-5910	-8.34% ✅
Sema.NumDeclsDeserialized	406573	365964	-40609	-9.99% ✅
Sema.NumLazyIterableDeclContexts	54859	49133	-5726	-10.44% ✅
Sema.NumLazyGenericEnvironments	65900	58932	-6968	-10.57% ✅
Sema.NumTypesDeserialized	344515	297416	-47099	-13.67% ✅
AST.NumTotalClangImportedEntities	75188	57132	-18056	-24.01% ✅
Sema.NumFunctionsTypechecked	17534	12708	-4826	-27.52% ✅
AST.NumImportedExternalDefinitions	28988	20266	-8722	-30.09% ✅
Sema.NumConstraintScopes	581970	312304	-269666	-46.34% ✅
Sema.NumTypesValidated	27944	14298	-13646	-48.83% ✅
Sema.NumGenericSignatureBuilders	33750	9644	-24106	-71.43% ✅
Sema.NumDeclsValidated	125016	9338	-115678	-92.53% ✅

Improved in ReactiveCocoa (13)

name	old	new	delta	delta_pct
SILModule.NumSILGenFunctions	2904	2892	-12	-0.41% ✅
AST.NumUsedConformances	704	700	-4	-0.57% ✅
IRModule.NumIRValueSymbols	14686	14568	-118	-0.8% ✅
IRModule.NumIRFunctions	7080	6914	-166	-2.34% ✅
Sema.NumTypesDeserialized	447750	437152	-10598	-2.37% ✅
IRModule.NumIRInsts	102753	98701	-4052	-3.94% ✅
Sema.NumLazyIterableDeclContexts	105954	98194	-7760	-7.32% ✅
IRModule.NumIRBasicBlocks	11870	10868	-1002	-8.44% ✅
Sema.NumLazyGenericEnvironmentsLoaded	10174	9212	-962	-9.46% ✅
Sema.NumConformancesDeserialized	57916	47294	-10622	-18.34% ✅
Sema.NumTypesValidated	49050	34536	-14514	-29.59% ✅
Sema.NumGenericSignatureBuilders	49468	23528	-25940	-52.44% ✅
Sema.NumDeclsValidated	106644	4712	-101932	-95.58% ✅

Improved in ReactiveSwift (19)

name	old	new	delta	delta_pct
SILModule.NumSILGenFunctions	4833	4813	-20	-0.41% ✅
AST.NumUsedConformances	730	724	-6	-0.82% ✅
IRModule.NumIRValueSymbols	19619	19287	-332	-1.69% ✅
IRModule.NumIRFunctions	10863	10541	-322	-2.96% ✅
IRModule.NumIRInsts	332161	314500	-17661	-5.32% ✅
Sema.NumConformancesDeserialized	49822	46804	-3018	-6.06% ✅
Sema.NumLazyGenericEnvironments	50740	47286	-3454	-6.81% ✅
Sema.NumDeclsDeserialized	291790	268499	-23291	-7.98% ✅
Sema.NumTypesDeserialized	253286	224862	-28424	-11.22% ✅
Sema.NumConstraintScopes	41650	36536	-5114	-12.28% ✅
IRModule.NumIRBasicBlocks	21814	19130	-2684	-12.3% ✅
Sema.NumFunctionsTypechecked	4538	3532	-1006	-22.17% ✅
Sema.NumLazyGenericEnvironmentsLoaded	7646	5932	-1714	-22.42% ✅
Sema.NumLazyIterableDeclContexts	37546	28270	-9276	-24.71% ✅
Sema.NumTypesValidated	100770	70786	-29984	-29.75% ✅
AST.NumImportedExternalDefinitions	6434	3454	-2980	-46.32% ✅
AST.NumTotalClangImportedEntities	24796	9062	-15734	-63.45% ✅
Sema.NumGenericSignatureBuilders	31134	8826	-22308	-71.65% ✅
Sema.NumDeclsValidated	75348	20562	-54786	-72.71% ✅

Unchanged (abs(delta) < 0.01% or 100000usec) (5)

Unchanged (abs(delta) < 0.01% or 100000usec) in Alamofire (2)

name	old	new	delta	delta_pct
Sema.NumDeclsDeserialized	193026	193046	20	0.01%
AST.NumLoadedModules	522	522	0	0.0%

Unchanged (abs(delta) < 0.01% or 100000usec) in Kingfisher (1)

name	old	new	delta	delta_pct
AST.NumLoadedModules	1323	1323	0	0.0%

Unchanged (abs(delta) < 0.01% or 100000usec) in ReactiveCocoa (1)

name	old	new	delta	delta_pct
AST.NumLoadedModules	3536	3536	0	0.0%

Unchanged (abs(delta) < 0.01% or 100000usec) in ReactiveSwift (1)

name	old	new	delta	delta_pct
AST.NumLoadedModules	880	880	0	0.0%

PR vs. baseline, changed timers (debug)

Regressed (0)

Improved (0)

Unchanged (abs(delta) < 0.01% or 1000000usec) (0)

Release

PR vs. head (release)

PR vs. head, changed counters (release)

Regressed (0)

Improved (0)

Unchanged (abs(delta) < 0.01% or 100000usec) (115)

Unchanged (abs(delta) < 0.01% or 100000usec) in Alamofire (23)

name	old	new	delta_pct
AST.NumImportedExternalDefinitions	881	881	0.0%
AST.NumLoadedModules	28	28	0.0%
AST.NumTotalClangImportedEntities	3234	3234	0.0%
AST.NumUsedConformances	432	432	0.0%
IRModule.NumIRBasicBlocks	15502	15502	0.0%
IRModule.NumIRFunctions	3579	3579	0.0%
IRModule.NumIRGlobals	4449	4449	0.0%
IRModule.NumIRInsts	113090	113090	0.0%
IRModule.NumIRValueSymbols	6898	6898	0.0%
LLVM.NumLLVMBytesOutput	3304536	3304536	0.0%
SILModule.NumSILGenFunctions	1860	1860	0.0%
SILModule.NumSILOptFunctions	3074	3074	0.0%
Sema.NumConformancesDeserialized	14472	14472	0.0%
Sema.NumConstraintScopes	36446	36446	0.0%
Sema.NumDeclsDeserialized	24138	24138	0.0%
Sema.NumDeclsValidated	3290	3290	0.0%
Sema.NumFunctionsTypechecked	1104	1104	0.0%
Sema.NumGenericSignatureBuilders	416	416	0.0%
Sema.NumLazyGenericEnvironments	2784	2784	0.0%
Sema.NumLazyGenericEnvironmentsLoaded	364	364	0.0%
Sema.NumLazyIterableDeclContexts	1660	1660	0.0%
Sema.NumTypesDeserialized	22904	22904	0.0%
Sema.NumTypesValidated	1592	1592	0.0%

Unchanged (abs(delta) < 0.01% or 100000usec) in Kingfisher (23)

name	old	new	delta	delta_pct
AST.NumImportedExternalDefinitions	3406	3406	0	0.0%
AST.NumLoadedModules	61	61	0	0.0%
AST.NumTotalClangImportedEntities	9850	9850	0	0.0%
AST.NumUsedConformances	850	850	0	0.0%
IRModule.NumIRBasicBlocks	22501	22501	0	0.0%
IRModule.NumIRFunctions	5795	5795	0	0.0%
IRModule.NumIRGlobals	8574	8574	0	0.0%
IRModule.NumIRInsts	166293	166293	0	0.0%
IRModule.NumIRValueSymbols	12767	12767	0	0.0%
LLVM.NumLLVMBytesOutput	5865796	5865792	-4	-0.0%
SILModule.NumSILGenFunctions	3056	3056	0	0.0%
SILModule.NumSILOptFunctions	5842	5842	0	0.0%
Sema.NumConformancesDeserialized	29184	29184	0	0.0%
Sema.NumConstraintScopes	301126	301126	0	0.0%
Sema.NumDeclsDeserialized	48343	48343	0	0.0%
Sema.NumDeclsValidated	4176	4176	0	0.0%
Sema.NumFunctionsTypechecked	2878	2878	0	0.0%
Sema.NumGenericSignatureBuilders	1101	1101	0	0.0%
Sema.NumLazyGenericEnvironments	4992	4992	0	0.0%
Sema.NumLazyGenericEnvironmentsLoaded	826	826	0	0.0%
Sema.NumLazyIterableDeclContexts	3535	3535	0	0.0%
Sema.NumTypesDeserialized	45237	45237	0	0.0%
Sema.NumTypesValidated	2740	2740	0	0.0%

Unchanged (abs(delta) < 0.01% or 100000usec) in ReactiveCocoa (23)

name	old	new	delta_pct
AST.NumImportedExternalDefinitions	3138	3138	0.0%
AST.NumLoadedModules	66	66	0.0%
AST.NumTotalClangImportedEntities	7480	7480	0.0%
AST.NumUsedConformances	700	700	0.0%
IRModule.NumIRBasicBlocks	8787	8787	0.0%
IRModule.NumIRFunctions	4876	4876	0.0%
IRModule.NumIRGlobals	8491	8491	0.0%
IRModule.NumIRInsts	66215	66215	0.0%
IRModule.NumIRValueSymbols	12101	12101	0.0%
LLVM.NumLLVMBytesOutput	8779700	8779700	0.0%
SILModule.NumSILGenFunctions	1913	1913	0.0%
SILModule.NumSILOptFunctions	3147	3147	0.0%
Sema.NumConformancesDeserialized	19444	19444	0.0%
Sema.NumConstraintScopes	37650	37650	0.0%
Sema.NumDeclsDeserialized	41916	41916	0.0%
Sema.NumDeclsValidated	2402	2402	0.0%
Sema.NumFunctionsTypechecked	2484	2484	0.0%
Sema.NumGenericSignatureBuilders	1280	1280	0.0%
Sema.NumLazyGenericEnvironments	6194	6194	0.0%
Sema.NumLazyGenericEnvironmentsLoaded	702	702	0.0%
Sema.NumLazyIterableDeclContexts	3784	3784	0.0%
Sema.NumTypesDeserialized	38983	38983	0.0%
Sema.NumTypesValidated	2372	2372	0.0%

Unchanged (abs(delta) < 0.01% or 100000usec) in ReactiveSwift (23)

name	old	new	delta_pct
AST.NumImportedExternalDefinitions	512	512	0.0%
AST.NumLoadedModules	38	38	0.0%
AST.NumTotalClangImportedEntities	2102	2102	0.0%
AST.NumUsedConformances	730	730	0.0%
IRModule.NumIRBasicBlocks	21272	21272	0.0%
IRModule.NumIRFunctions	10078	10078	0.0%
IRModule.NumIRGlobals	11646	11646	0.0%
IRModule.NumIRInsts	256157	256157	0.0%
IRModule.NumIRValueSymbols	19422	19422	0.0%
LLVM.NumLLVMBytesOutput	9961852	9961852	0.0%
SILModule.NumSILGenFunctions	3735	3735	0.0%
SILModule.NumSILOptFunctions	6934	6934	0.0%
Sema.NumConformancesDeserialized	24812	24812	0.0%
Sema.NumConstraintScopes	34930	34930	0.0%
Sema.NumDeclsDeserialized	44010	44010	0.0%
Sema.NumDeclsValidated	7578	7578	0.0%
Sema.NumFunctionsTypechecked	1976	1976	0.0%
Sema.NumGenericSignatureBuilders	1515	1515	0.0%
Sema.NumLazyGenericEnvironments	5184	5184	0.0%
Sema.NumLazyGenericEnvironmentsLoaded	828	828	0.0%
Sema.NumLazyIterableDeclContexts	2881	2881	0.0%
Sema.NumTypesDeserialized	39552	39552	0.0%
Sema.NumTypesValidated	23594	23594	0.0%

Unchanged (abs(delta) < 0.01% or 100000usec) in Result (23)

name	old	new	delta_pct
AST.NumImportedExternalDefinitions	316	316	0.0%
AST.NumLoadedModules	34	34	0.0%
AST.NumTotalClangImportedEntities	1300	1300	0.0%
AST.NumUsedConformances	62	62	0.0%
IRModule.NumIRBasicBlocks	2048	2048	0.0%
IRModule.NumIRFunctions	623	623	0.0%
IRModule.NumIRGlobals	687	687	0.0%
IRModule.NumIRInsts	20376	20376	0.0%
IRModule.NumIRValueSymbols	1194	1194	0.0%
LLVM.NumLLVMBytesOutput	482740	482740	0.0%
SILModule.NumSILGenFunctions	292	292	0.0%
SILModule.NumSILOptFunctions	813	813	0.0%
Sema.NumConformancesDeserialized	3922	3922	0.0%
Sema.NumConstraintScopes	3736	3736	0.0%
Sema.NumDeclsDeserialized	23858	23858	0.0%
Sema.NumDeclsValidated	472	472	0.0%
Sema.NumFunctionsTypechecked	296	296	0.0%
Sema.NumGenericSignatureBuilders	368	368	0.0%
Sema.NumLazyGenericEnvironments	4112	4112	0.0%
Sema.NumLazyGenericEnvironmentsLoaded	338	338	0.0%
Sema.NumLazyIterableDeclContexts	1976	1976	0.0%
Sema.NumTypesDeserialized	20510	20510	0.0%
Sema.NumTypesValidated	990	990	0.0%

PR vs. head, changed timers (release)

Regressed (0)

Improved (0)

Unchanged (abs(delta) < 0.01% or 1000000usec) (9)

Unchanged (abs(delta) < 0.01% or 1000000usec) in Alamofire (1)

name	old	new	delta	delta_pct
time.swift-driver.Alamofire-all-x86_64_apple_macosx10.10-o-O.wall	11036900	11022590	-14310	-0.13%

Unchanged (abs(delta) < 0.01% or 1000000usec) in Kingfisher (2)

name	old	new	delta	delta_pct
time.swift-driver.Kingfisher-all-arm64_apple_ios8.0-o-O.wall	11235200	11249150	13950	0.12%
time.swift-driver.Kingfisher-all-armv7_apple_ios8.0-o-O.wall	11525110	11420310	-104800	-0.91%

Unchanged (abs(delta) < 0.01% or 1000000usec) in ReactiveCocoa (2)

name	old	new	delta	delta_pct
time.swift-driver.ReactiveCocoa-all-armv7_apple_ios8.0-o-O.wall	5181890	5174613	-7277	-0.14%
time.swift-driver.ReactiveCocoa-all-arm64_apple_ios8.0-o-O.wall	5214518	5192896	-21622	-0.41%

Unchanged (abs(delta) < 0.01% or 1000000usec) in ReactiveSwift (2)

name	old	new	delta	delta_pct
time.swift-driver.ReactiveSwift-all-armv7_apple_ios8.0-o-O.wall	11053280	11021560	-31720	-0.29%
time.swift-driver.ReactiveSwift-all-arm64_apple_ios8.0-o-O.wall	10842610	10766790	-75820	-0.7%

Unchanged (abs(delta) < 0.01% or 1000000usec) in Result (2)

name	old	new	delta	delta_pct
time.swift-driver.Result-all-armv7_apple_ios8.0-o-O.wall	2892094	2869461	-22633	-0.78%
time.swift-driver.Result-all-arm64_apple_ios8.0-o-O.wall	2847734	2820983	-26751	-0.94%

PR vs. baseline (release)

PR vs. baseline, changed counters (release)

Regressed (16)

Regressed in Alamofire (3)

name	old	new	delta	delta_pct
AST.NumTotalClangImportedEntities	2920	3234	314	10.75% ⛔
LLVM.NumLLVMBytesOutput	3172156	3304536	132380	4.17% ⛔
SILModule.NumSILOptFunctions	2991	3074	83	2.77% ⛔

Regressed in Kingfisher (5)

name	old	new	delta	delta_pct
AST.NumTotalClangImportedEntities	9086	9850	764	8.41% ⛔
LLVM.NumLLVMBytesOutput	5462712	5865792	403080	7.38% ⛔
SILModule.NumSILOptFunctions	5723	5842	119	2.08% ⛔
AST.NumImportedExternalDefinitions	3368	3406	38	1.13% ⛔
Sema.NumFunctionsTypechecked	2848	2878	30	1.05% ⛔

Regressed in ReactiveCocoa (5)

name	old	new	delta	delta_pct
LLVM.NumLLVMBytesOutput	5480320	8779700	3299380	60.2% ⛔
Sema.NumConstraintScopes	23810	37650	13840	58.13% ⛔
SILModule.NumSILOptFunctions	2915	3147	232	7.96% ⛔
AST.NumTotalClangImportedEntities	7270	7480	210	2.89% ⛔
IRModule.NumIRGlobals	8486	8491	5	0.06% ⛔

Regressed in ReactiveSwift (3)

name	old	new	delta	delta_pct
LLVM.NumLLVMBytesOutput	9452416	9961852	509436	5.39% ⛔
SILModule.NumSILOptFunctions	6852	6934	82	1.2% ⛔
IRModule.NumIRGlobals	11628	11646	18	0.15% ⛔

Improved (67)

Improved in Alamofire (17)

name	old	new	delta	delta_pct
SILModule.NumSILGenFunctions	1861	1860	-1	-0.05% ✅
AST.NumUsedConformances	435	432	-3	-0.69% ✅
Sema.NumLazyGenericEnvironments	2814	2784	-30	-1.07% ✅
IRModule.NumIRGlobals	4521	4449	-72	-1.59% ✅
Sema.NumDeclsDeserialized	24875	24138	-737	-2.96% ✅
Sema.NumLazyIterableDeclContexts	1716	1660	-56	-3.26% ✅
Sema.NumTypesDeserialized	23832	22904	-928	-3.89% ✅
IRModule.NumIRValueSymbols	7218	6898	-320	-4.43% ✅
Sema.NumLazyGenericEnvironmentsLoaded	383	364	-19	-4.96% ✅
Sema.NumConstraintScopes	38683	36446	-2237	-5.78% ✅
IRModule.NumIRFunctions	3819	3579	-240	-6.28% ✅
IRModule.NumIRBasicBlocks	16869	15502	-1367	-8.1% ✅
IRModule.NumIRInsts	123248	113090	-10158	-8.24% ✅
Sema.NumConformancesDeserialized	16433	14472	-1961	-11.93% ✅
Sema.NumTypesValidated	1977	1592	-385	-19.47% ✅
Sema.NumGenericSignatureBuilders	1595	416	-1179	-73.92% ✅
Sema.NumDeclsValidated	17283	3290	-13993	-80.96% ✅

Improved in Kingfisher (16)

name	old	new	delta	delta_pct
IRModule.NumIRGlobals	8627	8574	-53	-0.61% ✅
AST.NumUsedConformances	858	850	-8	-0.93% ✅
Sema.NumDeclsDeserialized	48980	48343	-637	-1.3% ✅
Sema.NumTypesDeserialized	46208	45237	-971	-2.1% ✅
Sema.NumLazyIterableDeclContexts	3642	3535	-107	-2.94% ✅
Sema.NumLazyGenericEnvironments	5174	4992	-182	-3.52% ✅
IRModule.NumIRValueSymbols	13308	12767	-541	-4.07% ✅
Sema.NumConformancesDeserialized	30795	29184	-1611	-5.23% ✅
Sema.NumLazyGenericEnvironmentsLoaded	876	826	-50	-5.71% ✅
IRModule.NumIRFunctions	6265	5795	-470	-7.5% ✅
IRModule.NumIRBasicBlocks	25356	22501	-2855	-11.26% ✅
IRModule.NumIRInsts	189828	166293	-23535	-12.4% ✅
Sema.NumTypesValidated	3794	2740	-1054	-27.78% ✅
Sema.NumConstraintScopes	564928	301126	-263802	-46.7% ✅
Sema.NumGenericSignatureBuilders	3925	1101	-2824	-71.95% ✅
Sema.NumDeclsValidated	35702	4176	-31526	-88.3% ✅

Improved in ReactiveCocoa (15)

name	old	new	delta	delta_pct
SILModule.NumSILGenFunctions	1917	1913	-4	-0.21% ✅
Sema.NumLazyGenericEnvironments	6210	6194	-16	-0.26% ✅
AST.NumUsedConformances	704	700	-4	-0.57% ✅
IRModule.NumIRValueSymbols	12322	12101	-221	-1.79% ✅
Sema.NumDeclsDeserialized	42739	41916	-823	-1.93% ✅
Sema.NumTypesDeserialized	39750	38983	-767	-1.93% ✅
Sema.NumLazyIterableDeclContexts	3880	3784	-96	-2.47% ✅
Sema.NumLazyGenericEnvironmentsLoaded	728	702	-26	-3.57% ✅
IRModule.NumIRFunctions	5090	4876	-214	-4.2% ✅
IRModule.NumIRInsts	69895	66215	-3680	-5.27% ✅
IRModule.NumIRBasicBlocks	9437	8787	-650	-6.89% ✅
Sema.NumConformancesDeserialized	20926	19444	-1482	-7.08% ✅
Sema.NumTypesValidated	4072	2372	-1700	-41.75% ✅
Sema.NumGenericSignatureBuilders	3612	1280	-2332	-64.56% ✅
Sema.NumDeclsValidated	20206	2402	-17804	-88.11% ✅

Improved in ReactiveSwift (19)

name	old	new	delta	delta_pct
Sema.NumLazyGenericEnvironments	5196	5184	-12	-0.23% ✅
AST.NumUsedConformances	732	730	-2	-0.27% ✅
SILModule.NumSILGenFunctions	3755	3735	-20	-0.53% ✅
Sema.NumFunctionsTypechecked	1990	1976	-14	-0.7% ✅
Sema.NumDeclsDeserialized	44930	44010	-920	-2.05% ✅
IRModule.NumIRValueSymbols	19993	19422	-571	-2.86% ✅
Sema.NumLazyIterableDeclContexts	2982	2881	-101	-3.39% ✅
Sema.NumTypesDeserialized	40957	39552	-1405	-3.43% ✅
IRModule.NumIRFunctions	10605	10078	-527	-4.97% ✅
IRModule.NumIRInsts	271570	256157	-15413	-5.68% ✅
Sema.NumLazyGenericEnvironmentsLoaded	890	828	-62	-6.97% ✅
Sema.NumConformancesDeserialized	26845	24812	-2033	-7.57% ✅
Sema.NumConstraintScopes	38598	34930	-3668	-9.5% ✅
Sema.NumTypesValidated	26352	23594	-2758	-10.47% ✅
IRModule.NumIRBasicBlocks	23918	21272	-2646	-11.06% ✅
AST.NumImportedExternalDefinitions	592	512	-80	-13.51% ✅
AST.NumTotalClangImportedEntities	2670	2102	-568	-21.27% ✅
Sema.NumGenericSignatureBuilders	4390	1515	-2875	-65.49% ✅
Sema.NumDeclsValidated	28656	7578	-21078	-73.56% ✅

Unchanged (abs(delta) < 0.01% or 100000usec) (9)

Unchanged (abs(delta) < 0.01% or 100000usec) in Alamofire (3)

name	old	new	delta_pct
AST.NumImportedExternalDefinitions	881	881	0.0%
AST.NumLoadedModules	28	28	0.0%
Sema.NumFunctionsTypechecked	1104	1104	0.0%

Unchanged (abs(delta) < 0.01% or 100000usec) in Kingfisher (2)

name	old	new	delta	delta_pct
AST.NumLoadedModules	61	61	0	0.0%
SILModule.NumSILGenFunctions	3056	3056	0	0.0%

Unchanged (abs(delta) < 0.01% or 100000usec) in ReactiveCocoa (3)

name	old	new	delta_pct
AST.NumImportedExternalDefinitions	3138	3138	0.0%
AST.NumLoadedModules	66	66	0.0%
Sema.NumFunctionsTypechecked	2484	2484	0.0%

Unchanged (abs(delta) < 0.01% or 100000usec) in ReactiveSwift (1)

name	old	new	delta	delta_pct
AST.NumLoadedModules	38	38	0	0.0%

PR vs. baseline, changed timers (release)

Regressed (0)

Improved (0)

Unchanged (abs(delta) < 0.01% or 1000000usec) (0)

Last baseline commit on smoketest-master-debug.csv

commit 051207462e73c88493bbf2e49795efb88cb6c1ec
Author: Graydon Hoare 
Date:   Tue Oct 10 12:33:02 2017 -0700

    Update smoketest baselines for Swift version 4.0.1-dev (LLVM 2dedb62a0b, Clang ab7472e733, Swift 866e511daa)

Last baseline commit on smoketest-master-release.csv

commit 051207462e73c88493bbf2e49795efb88cb6c1ec
Author: Graydon Hoare 
Date:   Tue Oct 10 12:33:02 2017 -0700

    Update smoketest baselines for Swift version 4.0.1-dev (LLVM 2dedb62a0b, Clang ab7472e733, Swift 866e511daa)

DougGregor added 5 commits October 20, 2017 13:16

[GSB] Abstract away the PotentialArchetype stored in a constraint.

81d35d3

[GSB] Switch Constraint's "subject" over to an unresolved type.

fd191fe

We're still eagerly resolving the subject to a potential archetype everywhere, but this refactoring allows us to start introducing laziness.

[GSB] Move definition of GenericSignatureBuilder::Constraint out of t…

f379ba5

…he class. It's getting big, and there will soon be an ordering dependency with FloatingRequirementSource. NFC

[GSB] Start moving RequirementSource off of potential archetypes.

aa9755d

Eliminate potential archetypes from most of the public interface of RequirementSource.

[GSB] Eliminate potential archetypes from minimizing requirement sour…

1f09f3b

…ces. Refactor the interfaces that involve “walking” a requirement source (e.g., minimization, computation of the affected type, etc.) to rely only on interface types and not potential archetypes.

DougGregor added 3 commits October 20, 2017 21:38

[GSB] Eliminate potential archetypes from requirement sources entirely.

28e3e5c

[GSB] Teach expandConformanceRequirement() to use a resolved type.

972f048

Eliminates another too-early source of realization of potential archetypes.

[GSB] Eliminate a debugging-only source of potential archetype realiz…

42c1619

…ation.

slavapestov reviewed Oct 21, 2017

View reviewed changes

DougGregor added 4 commits October 23, 2017 10:39

[GSB] Eliminate most uses of PotentialArchetype::getBuilder().

a510e9b

The remaining two uses after this refactor are... stubborn.

[GSB] Eliminate the penultimate caller to PotentialArchetype::getBuil…

214f9d5

…der().

[GSB] Plumb generic params through getDependentType() fully.

2f3b2df

This allows us to eliminate `getBuilder()`.

DougGregor merged commit 44cef72 into swiftlang:master Oct 24, 2017

DougGregor deleted the gsb-requirement-source-without-potential-archetypes branch October 24, 2017 04:48

[GSB] Reduce use of potential archetypes when describing constraints #12536

[GSB] Reduce use of potential archetypes when describing constraints #12536

Uh oh!

Conversation

DougGregor commented Oct 20, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DougGregor commented Oct 20, 2017

Uh oh!

slavapestov Oct 21, 2017

Choose a reason for hiding this comment

Uh oh!

DougGregor Oct 23, 2017

Choose a reason for hiding this comment

Uh oh!

DougGregor Oct 23, 2017

Choose a reason for hiding this comment

Uh oh!

DougGregor commented Oct 23, 2017

Uh oh!

DougGregor commented Oct 23, 2017

Uh oh!

DougGregor commented Oct 23, 2017

Uh oh!

DougGregor commented Oct 23, 2017

Uh oh!

DougGregor commented Oct 23, 2017

Uh oh!

DougGregor commented Oct 23, 2017

Uh oh!

swift-ci commented Oct 23, 2017

Build comment file:

Compilation-performance test failed

Uh oh!

DougGregor commented Oct 24, 2017

Uh oh!

DougGregor commented Oct 24, 2017

Uh oh!

DougGregor commented Oct 24, 2017

Uh oh!

swift-ci commented Oct 24, 2017

Build comment file:

Summary for master smoketest

Debug

PR vs. head (debug)

PR vs. head, changed counters (debug)

PR vs. head, changed timers (debug)

PR vs. baseline (debug)

PR vs. baseline, changed counters (debug)

PR vs. baseline, changed timers (debug)

Release

PR vs. head (release)

PR vs. head, changed counters (release)

PR vs. head, changed timers (release)

PR vs. baseline (release)

PR vs. baseline, changed counters (release)

PR vs. baseline, changed timers (release)

Uh oh!

Uh oh!

DougGregor commented Oct 20, 2017 •

edited

Loading