[Sema] Fix for wrong callee candidate evaluation for complex args with unresolved parts. #12556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut even changing is<UnresolvedType> to hasUnresolvedType turns out is enough to fix a radar.
|
@swift-ci Please smoke test |
slavapestov
reviewed
Oct 22, 2017
| // the type could be anything, but it's still useful to save the argument as | ||
| // failureInfo. | ||
| if (!rArgType->hasUnresolvedType()) { | ||
| if (archetypesMap.empty()) |
There was a problem hiding this comment.
Nice! You'll soon discover the archetypeMap is a total disaster, BTW :-)
There was a problem hiding this comment.
Pretty sure it's of my making from generics diagnosis work a year or more ago, so it's karma. :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beginning changes to provide more info out about unresolved params, but even changing
is<UnresolvedType>()tohasUnresolvedType()turns out is enough to fix a radar...In this case, the partially unresolved function argument type caused wrong mismatches, when the first myMap should have been (and now is) a closer matching candidate.
Resolves radar 20142462 (apparently).