Skip to content

[SIL] Gardening: Change stale comment into a useful "NOTE:" #12580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2017
Merged

[SIL] Gardening: Change stale comment into a useful "NOTE:" #12580

merged 1 commit into from
Oct 24, 2017

Conversation

davezarzycki
Copy link
Contributor

  1. SILFunctionType and FunctionType no longer use the same ExtInfo data structure and therefore "strip" doesn't accurately describe what is going on.
  2. The 'no-escape' bit is clearly being preserved, while the 'throws' bit is clearly not.

@davezarzycki
[SIL] Gardening: Change stale comment into a useful "NOTE:"
b8530a7 
1) SILFunctionType and FunctionType no longer use the same ExtInfo data structure and therefore "strip" doesn't accurately describe what is going on.
2) The 'no-escape' bit is clearly being preserved, while the 'throws' bit is clearly not.
@davezarzycki
Copy link
Contributor Author

@swift-ci please smoke test

@davezarzycki davezarzycki merged commit 7778262 into swiftlang:master Oct 24, 2017
@davezarzycki davezarzycki deleted the nfc_sil_comment_fix branch October 24, 2017 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davezarzycki