Relax SILCombiner's archtype tracker: better existential_metatype support #12587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
Linux failure is unrelated - lib dispatch problem - just filed a bug https://bugs.swift.org/browse/SR-6205 |
slavapestov
reviewed
Oct 23, 2017
| // If we can't find the ExactConformance - bail | ||
| // We only encountered such situations in hand-written SIL (so far) | ||
| // Should take care of it nonetheless because to avoid a compiler crash | ||
| if (!ExactConformance.hasValue()) { |
There was a problem hiding this comment.
I think it's fine to assert on invalid SIL, even when hand-written. I'd rather shake out the cases where SILGen generates invalid SIL than have this
shajrawi
force-pushed
the
fix_silcombien_arch
branch
from
b09be81 to
8fdca7c
Compare
|
@swift-ci Please smoke test |
|
Thanks for doing the cleanup! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
radar rdar://problem/35052912
Fixes a bug in opened archetypes tracker wherein we did not handle
init_existential_metatype/open_existential_metatypecorrectly: the opened type can be the first operand in the meta-type variant.