libSyntax: ensure copy constructor of OwnedString to release previously allocated data. rdar://35116413 #12610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly allocated data. rdar://35116413 Issue detected by the awesome leak sanitizer bot.
|
@swift-ci please smoke test |
gottesmm
reviewed
Oct 25, 2017
include/swift/Basic/OwnedString.h
Outdated
| @@ -44,10 +44,15 @@ class OwnedString { | |||
| size_t Length; | |||
| StringOwnership Ownership; | |||
|
|
|||
| void release() { | |||
| if (Ownership == StringOwnership::Copied) | |||
| free(const_cast<char *>(Data)); | |||
There was a problem hiding this comment.
Quick drive by: Why are we freeing this. Why are we not using delete []?
On another note, I am just happy we are catching these leaks.
|
@swift-ci please smoke test |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
jrose-apple
reviewed
Oct 25, 2017
include/swift/Basic/OwnedString.h
Outdated
|
|
||
| OwnedString(const OwnedString &Other) { | ||
| // Release previously allocated data. | ||
| release(); |
There was a problem hiding this comment.
This can't happen. Are you sure it didn't mean the copy assignment operator?
(Also, you should probably add move operators as well. Rule of Five!)
There was a problem hiding this comment.
Oh, you’re right. This meant to be the copy assignment operator. Will fix
|
@jrose-apple could you please take another look? |
|
@swift-ci please smoke test |
jrose-apple
approved these changes
Oct 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue detected by the awesome leak sanitizer bot.
cc @gottesmm