Address John's feedback. #12612
Merged
Address John's feedback. #12612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test and merge |
|
For those reading in, John asked for 1 more comment addition, but I do not understand what he is saying yet. I thought I would just get these in real quick before I get home. I am going to do that comment change in another PR. |
gottesmm
force-pushed
the
pr-ecca9752729a232b491c1343641f4e81a2a3262a
branch
from
87c689d to
4c80c4d
Compare
|
@swift-ci smoke test and merge |
1 similar comment
|
@swift-ci smoke test and merge |
|
@rjmccall The follow up commit. |
|
Yeah, I saw. Looks fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically to commits:
36a8d0d
6df5462
rdar://31521023