Add SE-0186 to changelog. #12619
Merged
Add SE-0186 to changelog. #12619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slavapestov Let me know if you have any changes/suggestions. Thanks |
|
@slavapestov Just starting a drive by test. |
|
@swift-ci smoke test |
jrose-apple
reviewed
Oct 25, 2017
CHANGELOG.md
Outdated
|
|
||
| It is no longer valid to use the ownership keywords `weak` and `unowned` for property declarations in protocols. These keywords are meaningless and misleading when used in a protocol as they don't have any effect. | ||
|
|
||
| In Swift 3 and 4 mode the following example will produce a warning with a fixit to remove the keyword. In Swift 5 mode and above an error will be produced. |
There was a problem hiding this comment.
Thanks @jrose-apple , I've... fixed-it. :)
The changelog file is inconsistent with spelling and currently has 'fix-it', 'Fix-it' and 'Fix-It'. Any preference? I'll clean it up in a separate pull request if one style is preferred.
There was a problem hiding this comment.
@natecook1000 should check me on this, but I believe the correct spelling from Apple is "fix-it" (and "Fix-it" at the beginning of a sentence).
|
Looks good to merge once Jordan's feedback is addressed. Thank you! |
gspiers
force-pushed
the
add-SE-0186-to-changelog
branch
from
27b85d6 to
340c7f2
Compare
|
@swift-ci Please smoke test and merge |
1 similar comment
|
@swift-ci Please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an entry for SE-0186 to the changelog now that the implementation pull request has been merged into master.