[Sema] Allow non-escaping functions to be passed as subscript arguments #12671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
force-pushed
the
subscript-non-escaping-args
branch
from
04605ed to
7061b91
Compare
slavapestov
reviewed
Nov 2, 2017
lib/Sema/MiscDiagnostics.cpp
Outdated
| @@ -373,6 +381,18 @@ static void diagSyntacticUseRestrictions(TypeChecker &TC, const Expr *E, | |||
| } | |||
| } | |||
|
|
|||
| static void visitIndices(SubscriptExpr *subscript, | |||
| llvm::function_ref<void(unsigned, Expr*)> fn) { | |||
|
@swift-ci Please smoke test |
|
What Slava said, but otherwise LGTM. |
rjmccall
approved these changes
Nov 2, 2017
hamishknight
force-pushed
the
subscript-non-escaping-args
branch
from
7061b91 to
d734631
Compare
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, subscript arguments weren't specifically checked with
checkNoEscapeParameterUse, thereby preventing non-escaping functions from being passed as arguments to them. This PR adds that check.Fixes SR-6229.
(First-time contributing, so any and all feedback especially welcome!)