[Clang importer] Fix bridging of the underlying types of typedefs. #12680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typedefs tend to be imported without bridging the underlying type. However, when a typedef is used within a bridging context, we should bridge based on the underlying type. That wasn't being done consistently, causing us to import various typedefs without bridging at all. Update the logic to use the bridged underlying type whenever the (often unbridged) typedef type itself doesn't line up. Fixes rdar://problem/34913507. (cherry picked from commit 687d753)
|
@swift-ci please test |
|
Seems reasonable. |
|
@swift-ci please nominate Explanation: Typedefs of bridged types---such as |
|
@swift-ci please test source compatibility |
|
Hoping to supersede in #12737. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typedefs tend to be imported without bridging the underlying
type. However, when a typedef is used within a bridging context, we
should bridge based on the underlying type. That wasn't being done
consistently, causing us to import various typedefs without bridging
at all. Update the logic to use the bridged underlying type whenever
the (often unbridged) typedef type itself doesn't line up.
Fixes rdar://problem/34913507.
(cherry picked from commit 687d753)