-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Code Size: Outline copy addr instruction #12687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci Please clean test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with changes to refactor the repetitive code
6f8a18c
to
f4db364
Compare
@swift-ci Please clean test |
@swift-ci Please benchmark |
@aschwaighofer I refactored the code per your review |
Build comment file:Optimized (O)Regression (10)
Improvement (6)
No Changes (318)
Unoptimized (Onone)Regression (15)
Improvement (2)
No Changes (317)
Hardware Overview
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
We might have to make this conditional on Osize if some of the regressions are real
radar rdar://problem/33942466
Part 1 one
copy_addr
outlining: supports opaque existentials, address-only existentials, loadable types and loadable enums.