libSyntax: avoid copying token text when lexing token syntax nodes, NFC. #12723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is likely the root cause for memory surge when we always turn on syntax token lexing. Since the underlying buffer outlives the syntax tree, it's reasonable to refer the text instead of copying and owning it.
|
@swift-ci please smoke test |
nkcsgexi
added a commit
that referenced
this pull request
Nov 3, 2017
* Re-apply "libSyntax: Ensure round-trip printing when we build syntax tree from parser incrementally. (#12709)" * Re-apply "libSyntax: Root parsing context should hold a reference to the current token in the parser, NFC." * Re-apply "libSyntax: avoid copying token text when lexing token syntax nodes, NFC. (#12723)" * Actually fix the container-overflow issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is likely the root cause for the memory surge when we always turn on
syntax token lexing. Since the underlying buffer outlives the syntax
tree, it's reasonable to refer the text instead of copying and owning it.