Named lazy member loading write by default #12741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test and merge |
|
Ugh, no, this is wrong; getMembers() on extensions will add them to the extended type's IDC list. Will revisit tomorrow. |
|
Eh, on second thought this is guarded by E->wasDeserialized(), which means the members are already added if the extended type has an IDC list (and it's guarded by nominal->LookupTable.getPointer() in ExtensionDecl::addedMember anyways). I think this is ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns on @DougGregor's suggestion that we write the name lookup tables by default and only control their use by the command line flag.
Also fixes one class of bugs (of the ~35 remaining bugs) where named lazy loading doesn't quite work at runtime. Getting closer!